Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
index c8c3eb5920a986de3c4e6f033e3df0590c883a85..ee2e20c1409e8de52ac8ba96e0ea0c6250450ffc 100644
--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
@@ -12,7 +12,6 @@
#include "base/strings/string_number_conversions.h"
#include "base/time/time.h"
#include "components/ntp_snippets/category.h"
-#include "components/ntp_snippets/category_factory.h"
#include "components/ntp_snippets/content_suggestions_provider.h"
#include "components/ntp_snippets/mock_content_suggestions_provider_observer.h"
#include "components/ntp_snippets/offline_pages/offline_pages_test_utils.h"
@@ -68,12 +67,12 @@ class RecentTabSuggestionsProviderTest : public testing::Test {
RecentTabSuggestionsProvider::RegisterProfilePrefs(
pref_service()->registry());
- provider_.reset(new RecentTabSuggestionsProvider(
- &observer_, &category_factory_, &model_, pref_service()));
+ provider_.reset(
+ new RecentTabSuggestionsProvider(&observer_, &model_, pref_service()));
}
Category recent_tabs_category() {
- return category_factory_.FromKnownCategory(KnownCategories::RECENT_TABS);
+ return Category::FromKnownCategory(KnownCategories::RECENT_TABS);
}
ContentSuggestion::ID GetDummySuggestionId(int id) {
@@ -106,7 +105,6 @@ class RecentTabSuggestionsProviderTest : public testing::Test {
private:
FakeOfflinePageModel model_;
MockContentSuggestionsProviderObserver observer_;
- CategoryFactory category_factory_;
std::unique_ptr<TestingPrefServiceSimple> pref_service_;
// Last so that the dependencies are deleted after the provider.
std::unique_ptr<RecentTabSuggestionsProvider> provider_;

Powered by Google App Engine
This is Rietveld 408576698