components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc - Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)

Patch Set: rebase. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h ('k') | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

index f27892f36ac7236aa297cfa4efb0b9702dc8c488..6d689dbc17a334ba51b390aaf851538276813dc2 100644

--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

@@ -73,13 +73,12 @@ std::unique_ptr<OfflinePageModelQuery> BuildRecentTabsQuery(

RecentTabSuggestionsProvider::RecentTabSuggestionsProvider(

ContentSuggestionsProvider::Observer* observer,

- CategoryFactory* category_factory,

offline_pages::OfflinePageModel* offline_page_model,

PrefService* pref_service)

- : ContentSuggestionsProvider(observer, category_factory),

+ : ContentSuggestionsProvider(observer),

category_status_(CategoryStatus::AVAILABLE_LOADING),

provided_category_(

- category_factory->FromKnownCategory(KnownCategories::RECENT_TABS)),

+ Category::FromKnownCategory(KnownCategories::RECENT_TABS)),

offline_page_model_(offline_page_model),

pref_service_(pref_service),

weak_ptr_factory_(this) {