Remove use of deprecated API g_settings_list_schemas

Remove use of deprecated API g_settings_list_schemas

BUG=351911

[haltonhuo, 2014-04-28 02:19:44]

please review

[Paweł Hajdan Jr., 2014-04-28 11:02:49]

LGTM with comments. Thanks for the patch!

https://codereview.chromium.org/256803006/diff/1/net/proxy/proxy_config_servi...
File net/proxy/proxy_config_service_linux.cc (right):

https://codereview.chromium.org/256803006/diff/1/net/proxy/proxy_config_servi...
net/proxy/proxy_config_service_linux.cc:550: gchar **schemas;
Let's initialize this to NULL.

https://codereview.chromium.org/256803006/diff/1/net/proxy/proxy_config_servi...
net/proxy/proxy_config_service_linux.cc:553:
(g_settings_schema_source_get_default(), TRUE, &schemas, NULL);
nit: This is weird wrapping, could you move "(" to the previous line?

[szym, 2014-04-28 11:59:11]

lgtm stamp

[haltonhuo, 2014-04-29 07:47:27]

On 2014/04/28 11:02:49, Paweł Hajdan Jr. wrote:
> LGTM with comments. Thanks for the patch!
> 
>
https://codereview.chromium.org/256803006/diff/1/net/proxy/proxy_config_servi...
> File net/proxy/proxy_config_service_linux.cc (right):
> 
>
https://codereview.chromium.org/256803006/diff/1/net/proxy/proxy_config_servi...
> net/proxy/proxy_config_service_linux.cc:550: gchar **schemas;
> Let's initialize this to NULL.
> 
>
https://codereview.chromium.org/256803006/diff/1/net/proxy/proxy_config_servi...
> net/proxy/proxy_config_service_linux.cc:553:
> (g_settings_schema_source_get_default(), TRUE, &schemas, NULL);
> nit: This is weird wrapping, could you move "(" to the previous line?

Pawel, thanks for review. Patch set2 fixes your comment, I'm hitting the commit
checkbox.

[haltonhuo, 2014-04-29 07:47:31]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-04-29 07:48:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/halton.huo@intel.com/256803006/20001

[commit-bot: I haz the power, 2014-04-29 08:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 08:04:16]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Matt Giuca, 2014-04-29 23:46:49]

You're getting errors on the builders (which I believe run Ubuntu 12.04):
libgio.h:29:11: error: '::g_settings_schema_source_list_schemas' has not been
declared

Unfortunately, it looks like the replacement function was not available on
previous versions, so it isn't safe to use. Perhaps the best solution (until we
move our build infrastructure off 12.04) is to suppress the deprecation warning
for these files, instead of using the new version?

[haltonhuo, 2014-04-30 02:07:12]

On 2014/04/29 23:46:49, Matt Giuca wrote:
> You're getting errors on the builders (which I believe run Ubuntu 12.04):
> libgio.h:29:11: error: '::g_settings_schema_source_list_schemas' has not been
> declared
> 
> Unfortunately, it looks like the replacement function was not available on
> previous versions, so it isn't safe to use. Perhaps the best solution (until
we
> move our build infrastructure off 12.04) is to suppress the deprecation
warning
> for these files, instead of using the new version?

Alternatively, could use GLIB_CHECK_VERSION(2, 40, 0) to identify to use
different API on different glib version.

What do you think?

[haltonhuo, 2014-04-30 03:41:41]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-04-30 03:42:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/halton.huo@intel.com/256803006/20001

[commit-bot: I haz the power, 2014-04-30 04:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 04:03:27]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium

[Matt Giuca, 2014-05-01 03:08:23]

Oh good, there's a macro for it. Yeah, if you can use the different APIs
conditional on the GLIB_CHECK_VERSION macro, that would be great (add a comment
to say why you're doing it). I can test on 12.04 (or just rely on the try
servers).

[Matt Giuca, 2014-05-02 00:25:46]

Upon further consideration, I decided it wasn't right to conditionally compile
against different functions. Otherwise it will mean any Chrome binary built
against glib 2.40 will be incompatible with older versions. Better to disable
the warning for now, and continue using the old function (until it is actually
removed). I've prepared an alternative CL:
https://codereview.chromium.org/264963005

[Matt Giuca, 2014-05-02 00:28:27]

not lgtm, unless I'm missing something (e.g., it doesn't actually cause binaries
to be incompatible with previous versions, or we don't care for some reason).

[eroman, 2014-05-02 00:58:00]

lgtm

[eroman, 2014-05-02 00:58:27]

oops commented on wrong changelist!

[Paweł Hajdan Jr., 2014-05-05 11:25:30]

FYI https://codereview.chromium.org/264963005/ should also solve this.

[Matt Giuca, 2014-05-07 00:33:27]

https://codereview.chromium.org/264963005/ has been landed (SVN 268417). Can we
close this CL now?