Fix inheritance in Reading List

Fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169
Committed: https://crrev.com/f1a02a7dc245b360a3f78e19ef4bf06c8097fe67
Cr-Commit-Position: refs/heads/master@{#437850}

[Olivier, 2016-12-12 08:33:43]

Description was changed from

==========
fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169
==========

to

==========
Fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169
==========

[Olivier, 2016-12-12 08:33:56]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org, sdefresne@chromium.org

[gambard, 2016-12-12 08:46:30]

lgtm

[Olivier, 2016-12-12 09:30:24]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 09:30:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-12 09:33:24]

lgtm

https://codereview.chromium.org/2568023002/diff/1/components/reading_list/ios...
File components/reading_list/ios/reading_list_model_storage.h (right):

https://codereview.chromium.org/2568023002/diff/1/components/reading_list/ios...
components/reading_list/ios/reading_list_model_storage.h:31:
~ReadingListModelStorage() override{};
required: no semi-colon after method implementation

optional: since you have a .cc for the constructor implementation, I would
personally put the destructor implementation in the .cc file too.

[sdefresne, 2016-12-12 09:34:57]

On 2016/12/12 09:33:24, sdefresne wrote:
> lgtm
> 
>
https://codereview.chromium.org/2568023002/diff/1/components/reading_list/ios...
> File components/reading_list/ios/reading_list_model_storage.h (right):
> 
>
https://codereview.chromium.org/2568023002/diff/1/components/reading_list/ios...
> components/reading_list/ios/reading_list_model_storage.h:31:
> ~ReadingListModelStorage() override{};
> required: no semi-colon after method implementation
> 
> optional: since you have a .cc for the constructor implementation, I would
> personally put the destructor implementation in the .cc file too.

You'll also have to fix the unittests :-)

[commit-bot: I haz the power, 2016-12-12 09:35:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 09:35:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Olivier, 2016-12-12 10:19:37]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 10:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2016-12-12 10:20:17]

Done

https://codereview.chromium.org/2568023002/diff/1/components/reading_list/ios...
File components/reading_list/ios/reading_list_model_storage.h (right):

https://codereview.chromium.org/2568023002/diff/1/components/reading_list/ios...
components/reading_list/ios/reading_list_model_storage.h:31:
~ReadingListModelStorage() override{};
On 2016/12/12 09:33:24, sdefresne wrote:
> required: no semi-colon after method implementation
> 
> optional: since you have a .cc for the constructor implementation, I would
> personally put the destructor implementation in the .cc file too.

Done.

[Olivier, 2016-12-12 10:24:47]

The CQ bit was unchecked by olivierrobin@chromium.org

[Olivier, 2016-12-12 10:24:48]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2016-12-12 10:24:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
gambard@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2568023002/#ps40001
(title: "clean includes")

[commit-bot: I haz the power, 2016-12-12 10:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 11:59:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481538288232540,
"parent_rev": "28ea07adf1bde33b5dfc5d00f081dd3faf3ef6d4", "commit_rev":
"1d776292b1104ca78432446de7cbe415cc05c233"}

[commit-bot: I haz the power, 2016-12-12 12:00:09]

Description was changed from

==========
Fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169
==========

to

==========
Fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169

Review-Url: https://codereview.chromium.org/2568023002
==========

[commit-bot: I haz the power, 2016-12-12 12:00:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 15:11:34]

Description was changed from

==========
Fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169

Review-Url: https://codereview.chromium.org/2568023002
==========

to

==========
Fix inheritance in Reading List

Make ReadingListModelStorage inherit from syncer::ModelTypeSyncBridge.
ReadingList require the storage to implement USS so add a direct
inheritance to avoid multiple inheritance.

Mark ReadingListStoreDelegate constructor and destructor protected.
ReadingListStoreDelegate is an interface, mark constructor and destructor
protected.

BUG=673169

Committed: https://crrev.com/f1a02a7dc245b360a3f78e19ef4bf06c8097fe67
Cr-Commit-Position: refs/heads/master@{#437850}
==========

[commit-bot: I haz the power, 2016-12-12 15:11:35]

Patchset 3 (id:??) landed as
https://crrev.com/f1a02a7dc245b360a3f78e19ef4bf06c8097fe67
Cr-Commit-Position: refs/heads/master@{#437850}