DevTools: Fix 'Add new class' placeholder text

DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG=673223
Committed: https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c
Cr-Commit-Position: refs/heads/master@{#438282}

[phulce, 2016-12-12 23:00:44]

Description was changed from

==========
DevTools: Fix 'Add new class' placeholder text

BUG=
==========

to

==========
DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG=673223
==========

[phulce, 2016-12-12 23:00:44]

phulce@chromium.org changed reviewers:
+ einbinder@chromium.org, lushnikov@chromium.org

[lushnikov, 2016-12-12 23:15:35]

lgtm

https://codereview.chromium.org/2568013003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
(right):

https://codereview.chromium.org/2568013003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:13:
// Placeholder will be shown via CSS ::before by UI.TextPrompt
nit: let's drop the comment - the code below is descriptive enough

[einbinder, 2016-12-13 02:27:00]

https://codereview.chromium.org/2568013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
(right):

https://codereview.chromium.org/2568013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:22:
proxyElement.addEventListener('keydown', this._onKeyDown.bind(this), false);
After attaching,
this._prompt.setPlaceholder(Common.UIString('Add new class'));

So that we don't use the magic string 'data-placeholder' everywhere.

[phulce, 2016-12-13 19:05:47]

The CQ bit was checked by phulce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 19:06:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[einbinder, 2016-12-13 19:32:52]

lgtm

[commit-bot: I haz the power, 2016-12-13 21:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:08:06]

Dry run: This issue passed the CQ dry run.

[phulce, 2016-12-13 21:15:28]

The CQ bit was checked by phulce@chromium.org

[phulce, 2016-12-13 21:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2568013003/#ps40001
(title: "switch to setPlaceholder")

[commit-bot: I haz the power, 2016-12-13 21:15:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:35:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481663728519770,
"parent_rev": "9459fcc0333f8cf910b65fc74594b561c14dbdd5", "commit_rev":
"cc018c47e376c1d0679b76b20856560c9e4e29b9"}

[commit-bot: I haz the power, 2016-12-13 21:35:59]

Description was changed from

==========
DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG=673223
==========

to

==========
DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG=673223

Review-Url: https://codereview.chromium.org/2568013003
==========

[commit-bot: I haz the power, 2016-12-13 21:36:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 21:38:07]

Description was changed from

==========
DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG=673223

Review-Url: https://codereview.chromium.org/2568013003
==========

to

==========
DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG=673223

Committed: https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c
Cr-Commit-Position: refs/heads/master@{#438282}
==========

[commit-bot: I haz the power, 2016-12-13 21:38:08]

Patchset 3 (id:??) landed as
https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c
Cr-Commit-Position: refs/heads/master@{#438282}