Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2568013003: DevTools: Fix 'Add new class' placeholder text (Closed)

Created:
4 years ago by phulce
Modified:
4 years ago
Reviewers:
einbinder, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix 'Add new class' placeholder text Fixes bug where placeholder text disappeared on the Element tab's 'Add new class' input element. BUG=673223 Committed: https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c Cr-Commit-Position: refs/heads/master@{#438282}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove comment #

Total comments: 1

Patch Set 3 : switch to setPlaceholder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
phulce
4 years ago (2016-12-12 23:02:02 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/2568013003/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js (right): https://codereview.chromium.org/2568013003/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js#newcode13 third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:13: // Placeholder will be shown via CSS ::before ...
4 years ago (2016-12-12 23:15:35 UTC) #4
einbinder
https://codereview.chromium.org/2568013003/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js File third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js (right): https://codereview.chromium.org/2568013003/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js#newcode22 third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js:22: proxyElement.addEventListener('keydown', this._onKeyDown.bind(this), false); After attaching, this._prompt.setPlaceholder(Common.UIString('Add new class')); So ...
4 years ago (2016-12-13 02:27:00 UTC) #5
einbinder
lgtm
4 years ago (2016-12-13 19:32:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568013003/40001
4 years ago (2016-12-13 21:15:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-13 21:36:00 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 21:38:08 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c
Cr-Commit-Position: refs/heads/master@{#438282}

Powered by Google App Engine
This is Rietveld 408576698