Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 2567983008: FasterReload: remove default WebFrameLoadType from WebFrame::reload* (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FasterReload: remove default WebFrameLoadType from WebFrame::reload* Now, there are two callses that use WebFrameLoadType::Reload to call WebFrame::reloadWithOverrideURL(). These callers can be modified to use WebFrameLoadType::ReloadMainResoure insteads. Also, this change removes default argument from WebFrame::reload() and WebFrame::reloadWithOverrideURL() so to encourage using a right reload type for each caller respectively. Also this will be better in terms of coding style since default argument for virtual method is not recommended in chromium. BUG=670196 Committed: https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182 Cr-Commit-Position: refs/heads/master@{#438737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-14 09:03:21 UTC) #4
tkent
lgtm
4 years ago (2016-12-14 23:01:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567983008/1
4 years ago (2016-12-15 04:23:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 04:27:48 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 04:29:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182
Cr-Commit-Position: refs/heads/master@{#438737}

Powered by Google App Engine
This is Rietveld 408576698