Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2567963002: Change ComputedStyle::setWritingMode() to return void instead of bool (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 225dcbb2fea09328939f16314bf69bca5c2337fd..949545c3b94ba16efbeb2db579392bd459ac7ad1 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -2282,13 +2282,7 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
WritingMode getWritingMode() const {
return static_cast<WritingMode>(m_inheritedData.m_writingMode);
}
- bool setWritingMode(WritingMode v) {
- if (v == getWritingMode())
- return false;
-
- m_inheritedData.m_writingMode = v;
- return true;
- }
+ void setWritingMode(WritingMode v) { m_inheritedData.m_writingMode = v; }
// Text emphasis properties.
static TextEmphasisFill initialTextEmphasisFill() {

Powered by Google App Engine
This is Rietveld 408576698