Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2567963002: Change ComputedStyle::setWritingMode() to return void instead of bool (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 49d84c9545ea0007d229625bf1ab2e2d56d56948..c9f0b62b777e14bb1239ecc5c2bcc147596ea1de 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1953,8 +1953,11 @@ void LayoutObject::setStyleWithWritingModeOfParent(
void LayoutObject::addChildWithWritingModeOfParent(LayoutObject* newChild,
LayoutObject* beforeChild) {
- if (newChild->mutableStyleRef().setWritingMode(styleRef().getWritingMode()) &&
- newChild->isBoxModelObject()) {
+ const WritingMode oldWritingMode =
+ newChild->mutableStyleRef().getWritingMode();
+ const WritingMode newWritingMode = styleRef().getWritingMode();
+ if (oldWritingMode != newWritingMode && newChild->isBoxModelObject()) {
+ newChild->mutableStyleRef().setWritingMode(newWritingMode);
newChild->setHorizontalWritingMode(isHorizontalWritingMode());
}
addChild(newChild, beforeChild);

Powered by Google App Engine
This is Rietveld 408576698