exo: Produce an error if get_keyboard_device_configuration is called with a keyboard object that al…

exo: Produce an error if get_keyboard_device_configuration is called with a keyboard object that already is associated with a device configuration object.

BUG=670247
Committed: https://crrev.com/b6e3cbe5eca91e635a3947c29c1077916dd1f6f2
Cr-Commit-Position: refs/heads/master@{#438106}

[yhanada, 2016-12-12 06:26:47]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 06:26:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 06:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 06:52:18]

Dry run: This issue passed the CQ dry run.

[yhanada, 2016-12-12 06:58:07]

yhanada@chromium.org changed reviewers:
+ denniskempin@chromium.org, reveman@chromium.org

[yhanada, 2016-12-12 06:58:08]

Hi reveman@ and denniskempin@, PTAL.

[reveman, 2016-12-12 11:52:57]

thanks! lgtm % nits

https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc
File components/exo/keyboard.cc (right):

https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc#...
components/exo/keyboard.cc:118: return device_configuration_delegate_ !=
nullptr;
nit: !!device_configuration_delegate_ is preferred in exo code and I think
chromium in general too

https://codereview.chromium.org/2567903003/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2567903003/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:3061: if
(GetUserDataAs<Keyboard>(keyboard_resource)
nit: "Keyboard* keyboard = GetUserDataAs<Keyboard>(keyboard_resource)" above
this to avoid calling GetUserDataAs twice in this function

[yhanada, 2016-12-12 15:44:03]

Thanks for reviewing.

https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc
File components/exo/keyboard.cc (right):

https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc#...
components/exo/keyboard.cc:118: return device_configuration_delegate_ !=
nullptr;
On 2016/12/12 11:52:56, reveman wrote:
> nit: !!device_configuration_delegate_ is preferred in exo code and I think
> chromium in general too

Thanks for pointing it out. Done.

https://codereview.chromium.org/2567903003/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2567903003/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:3061: if
(GetUserDataAs<Keyboard>(keyboard_resource)
On 2016/12/12 11:52:56, reveman wrote:
> nit: "Keyboard* keyboard = GetUserDataAs<Keyboard>(keyboard_resource)" above
> this to avoid calling GetUserDataAs twice in this function

Done.

[yhanada, 2016-12-12 15:44:09]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 15:44:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 16:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:37:50]

Dry run: This issue passed the CQ dry run.

[yhanada, 2016-12-13 08:36:34]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2016-12-13 08:36:34]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2567903003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-13 08:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 09:16:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481618194138110,
"parent_rev": "4eae2c49404949fc95d710988d2a3f8ca5e199c1", "commit_rev":
"cd2ae5cd31cc23d3ae2eb4afadf58ddf26992cbf"}

[commit-bot: I haz the power, 2016-12-13 09:16:53]

Description was changed from

==========
exo: Produce an error if get_keyboard_device_configuration is called with a
keyboard object that already is associated with a device configuration object.

BUG=670247
==========

to

==========
exo: Produce an error if get_keyboard_device_configuration is called with a
keyboard object that already is associated with a device configuration object.

BUG=670247

Review-Url: https://codereview.chromium.org/2567903003
==========

[commit-bot: I haz the power, 2016-12-13 09:16:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 09:19:10]

Description was changed from

==========
exo: Produce an error if get_keyboard_device_configuration is called with a
keyboard object that already is associated with a device configuration object.

BUG=670247

Review-Url: https://codereview.chromium.org/2567903003
==========

to

==========
exo: Produce an error if get_keyboard_device_configuration is called with a
keyboard object that already is associated with a device configuration object.

BUG=670247

Committed: https://crrev.com/b6e3cbe5eca91e635a3947c29c1077916dd1f6f2
Cr-Commit-Position: refs/heads/master@{#438106}
==========

[commit-bot: I haz the power, 2016-12-13 09:19:11]

Patchset 3 (id:??) landed as
https://crrev.com/b6e3cbe5eca91e635a3947c29c1077916dd1f6f2
Cr-Commit-Position: refs/heads/master@{#438106}