Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2567903003: exo: Produce an error if get_keyboard_device_configuration is called with a keyboard object that al… (Closed)

Created:
4 years ago by yhanada
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Produce an error if get_keyboard_device_configuration is called with a keyboard object that already is associated with a device configuration object. BUG=670247 Committed: https://crrev.com/b6e3cbe5eca91e635a3947c29c1077916dd1f6f2 Cr-Commit-Position: refs/heads/master@{#438106}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address the comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M components/exo/keyboard.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/keyboard.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
yhanada
Hi reveman@ and denniskempin@, PTAL.
4 years ago (2016-12-12 06:58:08 UTC) #6
reveman
thanks! lgtm % nits https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc File components/exo/keyboard.cc (right): https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc#newcode118 components/exo/keyboard.cc:118: return device_configuration_delegate_ != nullptr; nit: ...
4 years ago (2016-12-12 11:52:57 UTC) #7
yhanada
Thanks for reviewing. https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc File components/exo/keyboard.cc (right): https://codereview.chromium.org/2567903003/diff/1/components/exo/keyboard.cc#newcode118 components/exo/keyboard.cc:118: return device_configuration_delegate_ != nullptr; On 2016/12/12 ...
4 years ago (2016-12-12 15:44:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567903003/40001
4 years ago (2016-12-13 08:36:57 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-13 09:16:54 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-13 09:19:11 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b6e3cbe5eca91e635a3947c29c1077916dd1f6f2
Cr-Commit-Position: refs/heads/master@{#438106}

Powered by Google App Engine
This is Rietveld 408576698