Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 25679008: Revert "Add support to load/store byte fields." and "MIPS: Add support to load/store byte fields.". (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert "Add support to load/store byte fields." and "MIPS: Add support to load/store byte fields.". This reverts commit r17079 and r17085. Will reland after fix. TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -166 lines) Patch
M src/arm/lithium-codegen-arm.cc View 5 chunks +8 lines, -32 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +6 lines, -11 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +14 lines, -40 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 5 chunks +8 lines, -32 lines 0 comments Download
M src/property-details.h View 4 chunks +1 line, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +28 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
Committed patchset #1 manually as r17099 (presubmit successful).
7 years, 2 months ago (2013-10-04 05:47:48 UTC) #1
Jakob Kummerow
7 years, 2 months ago (2013-10-04 08:24:11 UTC) #2
Message was sent while issue was closed.
LGTM.

For the record, reverting this wouldn't have been necessary, since AFAICS the
buggy code was effectively unreachable. Oh well.

Powered by Google App Engine
This is Rietveld 408576698