Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 25679008: Revert "Add support to load/store byte fields." and "MIPS: Add support to load/store byte fields.". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2042 matching lines...) Expand 10 before | Expand all | Expand 10 after
2053 context = UseRegister(instr->context()); 2053 context = UseRegister(instr->context());
2054 value = UseRegister(instr->value()); 2054 value = UseRegister(instr->value());
2055 temp = NULL; 2055 temp = NULL;
2056 } 2056 }
2057 LInstruction* result = new(zone()) LStoreContextSlot(context, value, temp); 2057 LInstruction* result = new(zone()) LStoreContextSlot(context, value, temp);
2058 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 2058 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
2059 } 2059 }
2060 2060
2061 2061
2062 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { 2062 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
2063 // Use the special mov rax, moffs64 encoding for external 2063 if (instr->access().IsExternalMemory() && instr->access().offset() == 0) {
2064 // memory accesses with 64-bit word-sized values.
2065 if (instr->access().IsExternalMemory() &&
2066 instr->access().offset() == 0 &&
2067 (instr->access().representation().IsSmi() ||
2068 instr->access().representation().IsTagged() ||
2069 instr->access().representation().IsHeapObject() ||
2070 instr->access().representation().IsExternal())) {
2071 LOperand* obj = UseRegisterOrConstantAtStart(instr->object()); 2064 LOperand* obj = UseRegisterOrConstantAtStart(instr->object());
2072 return DefineFixed(new(zone()) LLoadNamedField(obj), rax); 2065 return DefineFixed(new(zone()) LLoadNamedField(obj), rax);
2073 } 2066 }
2074 LOperand* obj = UseRegisterAtStart(instr->object()); 2067 LOperand* obj = UseRegisterAtStart(instr->object());
2075 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); 2068 return DefineAsRegister(new(zone()) LLoadNamedField(obj));
2076 } 2069 }
2077 2070
2078 2071
2079 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) { 2072 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) {
2080 LOperand* object = UseFixed(instr->object(), rax); 2073 LOperand* object = UseFixed(instr->object(), rax);
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
2544 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2537 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2545 LOperand* object = UseRegister(instr->object()); 2538 LOperand* object = UseRegister(instr->object());
2546 LOperand* index = UseTempRegister(instr->index()); 2539 LOperand* index = UseTempRegister(instr->index());
2547 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2540 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2548 } 2541 }
2549 2542
2550 2543
2551 } } // namespace v8::internal 2544 } } // namespace v8::internal
2552 2545
2553 #endif // V8_TARGET_ARCH_X64 2546 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698