DevTools: Add ability to add and edit cookies

third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

Index: third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js b/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
index 9554d691646b9aa711e433cacb464ee80e21285c..8bcb40ef01dda60f25ac70a587c1f4726643fbef 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
@@ -250,7 +250,7 @@ SDK.Cookie = class {
   }
 
   /**
-   * @return {string}
+   * @return {!Protocol.Network.CookieSameSite<string>}

[dgozman, 2016/12/14 17:20:21]

Never seen this syntax. What does it mean?

[kdzwinel, 2016/12/15 12:38:50]

AFAIK it means that we will return a 'Protocol.Network.CookieSameSite' which
effectively is a string. At some point I had a fight over using
{Protocol.Network.CookieSameSite} with a closure compiler, so I added <string>
part after seeing it here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...


I just tested, and <string> is no longer necessary, so I'll remove it.

[allada, 2016/12/15 23:45:52]

Lets focus on making this work for now. Please add a todo for me as follows:

// TODO(allada) This should not rely on _attributes and instead store them
individually.

on the line above the doctype.

Then just use:
@return {!Protocol.Network.CookieSameSite}

(and below)

[I started a patch that will update this area to modernize the code]

    */
   sameSite() {
     return this._attributes['samesite'];

[allada, 2016/12/15 23:45:52]

change this to:
return /** @type {!Protocol.Network.CookieSameSite} */
(this._attributes['samesite']);

@@ -287,7 +287,7 @@ SDK.Cookie = class {
   }
 
   /**
-   * @return {string}
+   * @return {number}

[allada, 2016/12/15 23:45:52]

We also parse headers out of this from network panel. This means that if a
cookie is set with an expires date in the header of a request and we display it
in the network panel it might do different than expected stuff.

I would suggest putting a condition where it sets the expiration in your code to
convert it into RFC5322 (https://tools.ietf.org/html/rfc5322#section-3.6.1)
format (what Date() uses) and convert to and from the string format.

[kdzwinel, 2016/12/19 01:55:04]

`expires` comes as a number from the back-end (`Network.getCookies`) and is also
expected to be a number when saving a cookie (`Network.setCookie`), so IMO I'd
be better to have a number here and fix the request header parser instead.
Please also note that `this._attributes['expires']` already stores numbers, not
strings (as jsdoc suggests), on the application panel. It only does strings on
the network panel. Since, as I understand form your comment below, you will be
rewriting this part of the code anyway, I switched the type back to string and
updated `SDK.Cookies._parseProtocolCookie` to make sure that `expires` is a
stirng in both network and application panel.

[allada, 2016/12/23 00:37:11]

Ok, lets keep it a number since 'expires' already is a number and we'll just be
extra careful when showing to users.

    */
   expires() {
     return this._attributes['expires'];
@@ -307,6 +307,10 @@ SDK.Cookie = class {
     return this._size;
   }
 
+  url() {
+    return (this.secure() ? 'https://' : 'http://') + this.domain() + this.path();
+  }
+
   /**
    * @param {number} size
    */
@@ -339,7 +343,7 @@ SDK.Cookie = class {
 
   /**
    * @param {string} key
-   * @param {string=} value
+   * @param {string|number=} value

[allada, 2016/12/15 23:45:52]

I have some code that is going to be changing this a lot. If it doesn't make the
rest of the code bad, lets just convert anything that would come in as a number
to a string instead.

    */
   addAttribute(key, value) {
     this._attributes[key.toLowerCase()] = value;
@@ -349,8 +353,19 @@ SDK.Cookie = class {
    * @param {function(?Protocol.Error)=} callback
    */
   remove(callback) {
-    this._target.networkAgent().deleteCookie(
-        this.name(), (this.secure() ? 'https://' : 'http://') + this.domain() + this.path(), callback);
+    this._target.networkAgent().deleteCookie(this.name(), this.url(), callback);
+  }
+
+  /**
+   * @param {function(?Protocol.Error, boolean)=} callback
+   */
+  save(callback) {
+    var domain = this.domain();
+    // for cookies targeting single domain and no sub domains 'domain' field should be sent empty

[allada, 2016/12/15 23:45:52]

I would suggest removing this code as it is not relevant to devtools.

But, for future reference we start with caps and end in period for comments. :-)

+    if (!domain.startsWith('.'))
+      domain = '';
+    this._target.networkAgent().setCookie(this.url(), this.name(), this.value(), domain, this.path(), this.secure(),
+      this.httpOnly(), this.sameSite(), this.expires(), callback);
   }
 };