third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js - Issue 2567873002: DevTools: Add ability to add and edit cookies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

Issue 2567873002: DevTools: Add ability to add and edit cookies (Closed)

Patch Set: Code review fixes - part 3. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js ('K') | « third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

index c3346448c25157813f11d2f4b6228260a7e842bb..65f3b48cb7f634a8f8d94e55748b2e199037e780 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js

@@ -103,8 +103,9 @@ Resources.CookieItemsView = class extends UI.SimpleView {

}

if (!this._cookiesTable) {

+ const parsedURL = this._cookieDomain.asParsedURL();

dgozman 2016/12/14 17:20:21 Note that asParsedURL can return null.

this._cookiesTable =

- new Components.CookiesTable(false, this._update.bind(this), this._showDeleteButton.bind(this));

+ new Components.CookiesTable(false, this._update.bind(this), this._showDeleteButton.bind(this), parsedURL.domain());

}

this._cookiesTable.setCookies(this._cookies);