replace flaky DCHECK in DrawingBuffer with early-out

replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/4e3dcfb51d796f4b360216afef4da397aca22728
Cr-Commit-Position: refs/heads/master@{#437689}

[Kai Ninomiya, 2016-12-09 19:17:19]

Description was changed from

==========
replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
==========

to

==========
replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-12-09 19:17:44]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[Kai Ninomiya, 2016-12-09 19:18:07]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org

[Kai Ninomiya, 2016-12-09 19:18:07]

PTAL

[commit-bot: I haz the power, 2016-12-09 19:18:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-12-09 21:23:50]

lgtm with comment added.

https://codereview.chromium.org/2567733002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp (right):

https://codereview.chromium.org/2567733002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp:716: if
(!produceSyncToken.HasData()) {
Please add a comment that this should really only happen if the context's been
lost. Unfortunately, I think it would be too flaky to add a DCHECK here that
m_gl->GetGraphicsResetStatusKHR() != NO_ERROR. The specification of this
extension only guarantees that the lost context notification is delivered once.

[Kai Ninomiya, 2016-12-09 21:28:33]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-12-09 21:28:34]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2567733002/#ps20001
(title: "add comment + rebase")

[commit-bot: I haz the power, 2016-12-09 21:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 23:27:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481318913661710,
"parent_rev": "fc3e863cf94ca4842264f33c9f7f76bc63fb3e41", "commit_rev":
"e57b53d5a6fa5be98a51ec2751e218beb73266ff"}

[commit-bot: I haz the power, 2016-12-09 23:28:18]

Description was changed from

==========
replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567733002
==========

[commit-bot: I haz the power, 2016-12-09 23:28:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 14:58:16]

Description was changed from

==========
replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567733002
==========

to

==========
replace flaky DCHECK in DrawingBuffer with early-out

BUG=648377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/4e3dcfb51d796f4b360216afef4da397aca22728
Cr-Commit-Position: refs/heads/master@{#437689}
==========

[commit-bot: I haz the power, 2016-12-12 14:58:18]

Patchset 2 (id:??) landed as
https://crrev.com/4e3dcfb51d796f4b360216afef4da397aca22728
Cr-Commit-Position: refs/heads/master@{#437689}