Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 256773006: Measure Event.returnValue usage in more detail (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
Reviewers:
Inactive, eseidel
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Measure Event.returnValue usage in more detail As suggested by Boris Zbarsky: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25002#c2 BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172829

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M Source/core/events/Event.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/events/Event.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M Source/core/events/Event.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
6 years, 7 months ago (2014-04-28 21:22:35 UTC) #1
Inactive
Considering that both Gecko and IE don't support this anymore, and knowing that popular libraries ...
6 years, 7 months ago (2014-04-28 21:31:15 UTC) #2
philipj_slow
I'm also hopeful that it can be removed, but I'm not confident enough to propose ...
6 years, 7 months ago (2014-04-28 21:52:19 UTC) #3
eseidel
lgtm
6 years, 7 months ago (2014-04-28 22:38:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/256773006/20001
6 years, 7 months ago (2014-04-28 22:39:31 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 03:35:17 UTC) #6
Message was sent while issue was closed.
Change committed as 172829

Powered by Google App Engine
This is Rietveld 408576698