Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4314)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

Issue 2567673002: Factor getCertificateChain out of ConnectionPopupInfo (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java
index b99c9289cf39f4ef698b1414c2e7c99c304d2893..6853d9bfee862f95220395d23142a1b720e61c42 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java
@@ -228,6 +228,10 @@ public class ConnectionInfoPopup implements OnClickListener {
}
}
+ public static byte[][] getCertificateChain(WebContents webContents) {
please use gerrit instead 2016/12/09 17:16:01 It would be best to place this in a separate class
+ return nativeGetCertificateChain(webContents);
+ }
+
/**
* Shows a connection info dialog for the provided WebContents.
*
@@ -247,5 +251,5 @@ public class ConnectionInfoPopup implements OnClickListener {
private native void nativeDestroy(long nativeConnectionInfoPopupAndroid);
private native void nativeResetCertDecisions(
long nativeConnectionInfoPopupAndroid, WebContents webContents);
- private native byte[][] nativeGetCertificateChain(WebContents webContents);
+ private static native byte[][] nativeGetCertificateChain(WebContents webContents);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698