Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

Issue 2567673002: Factor getCertificateChain out of ConnectionPopupInfo (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.pageinfo; 5 package org.chromium.chrome.browser.pageinfo;
6 6
7 import android.app.Dialog; 7 import android.app.Dialog;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.DialogInterface; 9 import android.content.DialogInterface;
10 import android.content.Intent; 10 import android.content.Intent;
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 i.putExtra(Browser.EXTRA_CREATE_NEW_TAB, true); 221 i.putExtra(Browser.EXTRA_CREATE_NEW_TAB, true);
222 i.putExtra(Browser.EXTRA_APPLICATION_ID, mContext.getPackageName ()); 222 i.putExtra(Browser.EXTRA_APPLICATION_ID, mContext.getPackageName ());
223 mContext.startActivity(i); 223 mContext.startActivity(i);
224 } catch (Exception ex) { 224 } catch (Exception ex) {
225 // Do nothing intentionally. 225 // Do nothing intentionally.
226 Log.w(TAG, "Bad URI %s", mLinkUrl, ex); 226 Log.w(TAG, "Bad URI %s", mLinkUrl, ex);
227 } 227 }
228 } 228 }
229 } 229 }
230 230
231 public static byte[][] getCertificateChain(WebContents webContents) {
please use gerrit instead 2016/12/09 17:16:01 It would be best to place this in a separate class
232 return nativeGetCertificateChain(webContents);
233 }
234
231 /** 235 /**
232 * Shows a connection info dialog for the provided WebContents. 236 * Shows a connection info dialog for the provided WebContents.
233 * 237 *
234 * The popup adds itself to the view hierarchy which owns the reference whil e it's 238 * The popup adds itself to the view hierarchy which owns the reference whil e it's
235 * visible. 239 * visible.
236 * 240 *
237 * @param context Context which is used for launching a dialog. 241 * @param context Context which is used for launching a dialog.
238 * @param webContents The WebContents for which to show Website information. This 242 * @param webContents The WebContents for which to show Website information. This
239 * information is retrieved for the visible entry. 243 * information is retrieved for the visible entry.
240 */ 244 */
241 public static void show(Context context, WebContents webContents) { 245 public static void show(Context context, WebContents webContents) {
242 new ConnectionInfoPopup(context, webContents); 246 new ConnectionInfoPopup(context, webContents);
243 } 247 }
244 248
245 private static native long nativeInit(ConnectionInfoPopup popup, 249 private static native long nativeInit(ConnectionInfoPopup popup,
246 WebContents webContents); 250 WebContents webContents);
247 private native void nativeDestroy(long nativeConnectionInfoPopupAndroid); 251 private native void nativeDestroy(long nativeConnectionInfoPopupAndroid);
248 private native void nativeResetCertDecisions( 252 private native void nativeResetCertDecisions(
249 long nativeConnectionInfoPopupAndroid, WebContents webContents); 253 long nativeConnectionInfoPopupAndroid, WebContents webContents);
250 private native byte[][] nativeGetCertificateChain(WebContents webContents); 254 private static native byte[][] nativeGetCertificateChain(WebContents webCont ents);
251 } 255 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698