Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 25676002: base: Fix MemoryPressureListener documentation (Closed)

Created:
7 years, 2 months ago by boliu
Modified:
7 years, 2 months ago
Reviewers:
bulach, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

base: Fix MemoryPressureListener documentation ObserverListThreadSafe will call PostTask on all observer callbacks, even those on the same thread. So correct the comment in MemoryPressureListener which states callbacks on the same thread as the system broadcast are called synchronously. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M base/memory/memory_pressure_listener.h View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
Marcus, do you think we should fix ObserverListThreadSafe to make this guarantee correct?
7 years, 2 months ago (2013-10-02 03:34:34 UTC) #1
bulach
lgtm, I think it's fine to just update the documentation... the graphs we're collecting shows ...
7 years, 2 months ago (2013-10-02 16:56:28 UTC) #2
boliu
On 2013/10/02 16:56:28, bulach wrote: > lgtm, I think it's fine to just update the ...
7 years, 2 months ago (2013-10-02 17:05:33 UTC) #3
boliu
+thakis for base owners
7 years, 2 months ago (2013-10-02 17:08:39 UTC) #4
Nico
lgtm
7 years, 2 months ago (2013-10-02 17:51:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/25676002/1
7 years, 2 months ago (2013-10-02 17:55:11 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 17:57:12 UTC) #7
Message was sent while issue was closed.
Change committed as 226497

Powered by Google App Engine
This is Rietveld 408576698