Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2567583002: Use name attribute not id attribute for anchor tag in Markdown (Closed)

Created:
4 years ago by amoylan
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use name attribute not id attribute for anchor tag in Markdown Per dpranke, it seems Gerrit strips out <a id=foo> anchors. BUG= Committed: https://crrev.com/a960fa5f4025ea3b59bdb9bb424ede189ba375f9 Cr-Commit-Position: refs/heads/master@{#437673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M docs/linux_build_instructions.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
amoylan
4 years ago (2016-12-09 04:51:33 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-12-09 05:43:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567583002/1
4 years ago (2016-12-09 20:34:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 22:48:03 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-12 14:57:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a960fa5f4025ea3b59bdb9bb424ede189ba375f9
Cr-Commit-Position: refs/heads/master@{#437673}

Powered by Google App Engine
This is Rietveld 408576698