Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2567533002: Add ScopedAllowIO in WebrtcTransport when shutting down WebRTC session. (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedAllowIO in WebrtcTransport when shutting down WebRTC session. PeerConnection creates new threads internally and shuts them down when connection is closed. This is a blocking operation, so Debug builds were DCHECK'ing every time connection is terminated. Added ScopedAllowIO to work around this issue. BUG=660081 Committed: https://crrev.com/2c41f984a001aa9f1c686ef2d888fdfa1fcaea23 Cr-Commit-Position: refs/heads/master@{#437711}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Sergey Ulanov
jochen@, please approve PRESUBMIT.py change jamiewalch@, please review webrtc_transport.cc
4 years ago (2016-12-09 01:53:34 UTC) #3
jochen (gone - plz use gerrit)
deferring to jam@, master of ScopedAllowIO
4 years ago (2016-12-09 08:26:42 UTC) #5
jam
rs lgtm anyone can add ScopedAllowIO (I'm more concerned with ScopedAllowWait, which incidentally is what ...
4 years ago (2016-12-09 17:21:13 UTC) #6
Jamie
lgtm
4 years ago (2016-12-09 23:07:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567533002/20001
4 years ago (2016-12-09 23:19:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-12-10 01:21:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567533002/20001
4 years ago (2016-12-10 01:27:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-10 01:45:52 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-12 14:59:13 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c41f984a001aa9f1c686ef2d888fdfa1fcaea23
Cr-Commit-Position: refs/heads/master@{#437711}

Powered by Google App Engine
This is Rietveld 408576698