Fix P-521 client cert mapping and test all curves.

Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972
Committed: https://crrev.com/b9b243bd7562a54a6cc4f80f1b23ebc9b8c37d9b
Cr-Commit-Position: refs/heads/master@{#437963}

[davidben, 2016-12-09 20:47:49]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 20:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-12-09 21:29:01]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 21:29:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-12-09 21:44:11]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[davidben, 2016-12-09 21:44:26]

Description was changed from

==========
Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests ever-so-slightly closer to sane.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972
==========

to

==========
Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972
==========

[commit-bot: I haz the power, 2016-12-09 21:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-12-09 21:45:00]

davidben@chromium.org changed reviewers:
+ svaldez@chromium.org

[svaldez, 2016-12-09 21:54:23]

lgtm

[davidben, 2016-12-09 22:57:48]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2016-12-09 22:57:53]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-12-09 22:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:12:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-12-10 01:20:57]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:21:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 04:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 04:18:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-12-10 04:39:52]

On 2016/12/10 04:18:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Bah. Right. Other files need to get regenerated when we update things. Sigh.

[davidben, 2016-12-12 19:47:53]

davidben@chromium.org changed reviewers:
+ emaxx@chromium.org

[davidben, 2016-12-12 19:47:54]

emaxx: Please review chrome/test/data/extensions/api_test/platform_keys. I added
a script so at least updating it will be faster next time, but those tests
should not have been written assuming data in //net will not change.

[davidben, 2016-12-12 19:48:16]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 19:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 19:53:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 19:53:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[emaxx, 2016-12-12 20:03:19]

LGTM

Sorry for these hardcoded values in the platform_keys API tests.
This issue was filed under crbug.com/591193, but I haven't worked on it yet.
Thanks for making the helper script!

[davidben, 2016-12-12 20:03:23]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[davidben, 2016-12-12 20:04:30]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2016-12-12 20:04:33]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-12-12 20:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/2567523003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-12 20:04:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-12-12 20:04:49]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2016-12-12 20:05:33]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-12-12 20:06:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 20:11:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 20:11:07]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[davidben, 2016-12-12 20:43:32]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-12-12 20:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
svaldez@chromium.org, emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2567523003/#ps100001
(title: "reupload with hack to depot_tools")

[commit-bot: I haz the power, 2016-12-12 20:45:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:56:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481575412515660,
"parent_rev": "754426b698e78c8e456b10f99e64a98087b8ead0", "commit_rev":
"702e4d3bbf04f00e95e2e974c7d1503e1531168d"}

[commit-bot: I haz the power, 2016-12-12 23:57:20]

Description was changed from

==========
Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972
==========

to

==========
Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972

Review-Url: https://codereview.chromium.org/2567523003
==========

[commit-bot: I haz the power, 2016-12-12 23:57:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-13 00:01:07]

Description was changed from

==========
Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972

Review-Url: https://codereview.chromium.org/2567523003
==========

to

==========
Fix P-521 client cert mapping and test all curves.

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972

Committed: https://crrev.com/b9b243bd7562a54a6cc4f80f1b23ebc9b8c37d9b
Cr-Commit-Position: refs/heads/master@{#437963}
==========

[commit-bot: I haz the power, 2016-12-13 00:01:08]

Patchset 6 (id:??) landed as
https://crrev.com/b9b243bd7562a54a6cc4f80f1b23ebc9b8c37d9b
Cr-Commit-Position: refs/heads/master@{#437963}