mash: Have chrome set itself as the app list presenter.

mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chromium.org

Committed: https://crrev.com/982c17a70a9c06b191b96e6e77f78933d0989de4
Cr-Commit-Position: refs/heads/master@{#438044}

[msw, 2016-12-09 21:46:30]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 21:47:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-12-09 23:05:30]

Description was changed from

==========
mash: Have chrome set itself as the app list presenter.

BUG=670775
==========

to

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org
==========

[msw, 2016-12-09 23:05:30]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-12-09 23:05:47]

Hey James, please take a look; thanks!

[commit-bot: I haz the power, 2016-12-09 23:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:40:42]

Dry run: This issue passed the CQ dry run.

[msw, 2016-12-10 00:36:13]

msw@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[msw, 2016-12-10 00:36:13]

Hey Mikhail, would you please also take a look? Thanks!

[James Cook, 2016-12-10 00:50:08]

LGTM with nits

https://codereview.chromium.org/2567523002/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2567523002/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:20: #include "ui/app_list/presenter/app_list.h"
Hmm. I've been trying to avoid dependencies in wm_shell.h and shell.h for mojom
headers, since those headers are heavy and wm_shell.h is included everywhere.

Can this be forward declared?

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/app_list_presen...
File ash/mus/app_list_presenter_mus.cc (right):

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:6: #include "ash/mus/app_list_presenter_mus.h"
nit: goes at top of file

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:16: if
(WmShell::Get()->app_list()->GetAppListPresenter())
nit: cache either the result of WmShell::Get() or WmShell::Get()->app_list() in
a local, and below

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/shell_delegate_...
File ash/mus/shell_delegate_mus.cc (right):

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/shell_delegate_...
ash/mus/shell_delegate_mus.cc:22: #include
"ui/app_list/presenter/app_list_presenter.h"
not needed?

https://codereview.chromium.org/2567523002/diff/40001/ui/app_list/presenter/a...
File ui/app_list/presenter/app_list_presenter.mojom (right):

https://codereview.chromium.org/2567523002/diff/40001/ui/app_list/presenter/a...
ui/app_list/presenter/app_list_presenter.mojom:9: // TODO(msw): Rename this file
to app_list.mojom; move to ash?
Yeah, if we can prove that ash is the only app list consumer these days we ought
to move everything there.

[msw, 2016-12-10 00:55:40]

Description was changed from

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org
==========

to

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org
==========

[msw, 2016-12-10 00:55:40]

msw@chromium.org changed reviewers:
+ tsepez@chromium.org

[msw, 2016-12-10 00:56:13]

+Tom for mojom and manifest OWNERS, please take a look; thanks!

[msw, 2016-12-10 01:06:55]

Description was changed from

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org
==========

to

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chrom...
==========

[msw, 2016-12-10 01:06:55]

msw@chromium.org changed reviewers:
+ rockot@chromium.org, xiyuan@chromium.org

[msw, 2016-12-10 01:08:12]

Xiyuan, please take a look at ui/app_list and chrome_interface_factory.cc
Ken, please take a look at the +mojo/public/cpp in ui/app_list/DEPS.
Thanks!

https://codereview.chromium.org/2567523002/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2567523002/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:20: #include "ui/app_list/presenter/app_list.h"
On 2016/12/10 00:50:08, James Cook wrote:
> Hmm. I've been trying to avoid dependencies in wm_shell.h and shell.h for
mojom
> headers, since those headers are heavy and wm_shell.h is included everywhere.
> 
> Can this be forward declared?

Done.

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/app_list_presen...
File ash/mus/app_list_presenter_mus.cc (right):

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:6: #include "ash/mus/app_list_presenter_mus.h"
On 2016/12/10 00:50:08, James Cook wrote:
> nit: goes at top of file

Done.

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:16: if
(WmShell::Get()->app_list()->GetAppListPresenter())
On 2016/12/10 00:50:08, James Cook wrote:
> nit: cache either the result of WmShell::Get() or WmShell::Get()->app_list()
in
> a local, and below

Done.

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/shell_delegate_...
File ash/mus/shell_delegate_mus.cc (right):

https://codereview.chromium.org/2567523002/diff/40001/ash/mus/shell_delegate_...
ash/mus/shell_delegate_mus.cc:22: #include
"ui/app_list/presenter/app_list_presenter.h"
On 2016/12/10 00:50:08, James Cook wrote:
> not needed?

Done.

https://codereview.chromium.org/2567523002/diff/40001/ui/app_list/presenter/a...
File ui/app_list/presenter/app_list_presenter.mojom (right):

https://codereview.chromium.org/2567523002/diff/40001/ui/app_list/presenter/a...
ui/app_list/presenter/app_list_presenter.mojom:9: // TODO(msw): Rename this file
to app_list.mojom; move to ash?
On 2016/12/10 00:50:08, James Cook wrote:
> Yeah, if we can prove that ash is the only app list consumer these days we
ought
> to move everything there.

Acknowledged.

[msw, 2016-12-10 01:08:19]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 01:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-10 01:21:41]

lgtm

[commit-bot: I haz the power, 2016-12-10 03:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:41:34]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-12 16:29:31]

On 2016/12/10 01:21:41, Ken Rockot wrote:
> lgtm

When swapping "conectors" and "connectees", so to speak, the issue is whether
there is a possibility for impersonation that didn't previously exist.  How does
ash know that it's really chrome that's registering with it?

[Tom Sepez, 2016-12-12 16:30:12]

On 2016/12/12 16:29:31, Tom Sepez wrote:
> On 2016/12/10 01:21:41, Ken Rockot wrote:
> > lgtm
> 
> When swapping "conectors" and "connectees", so to speak, the issue is whether
> there is a possibility for impersonation that didn't previously exist.  How
does
> ash know that it's really chrome that's registering with it?

Mojom itself is fine.

[xiyuan, 2016-12-12 16:59:07]

ui/app_list and chrome_interface_factory.cc lgtm

[msw, 2016-12-12 19:20:56]

The CQ bit was checked by msw@chromium.org

[msw, 2016-12-12 19:20:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2567523002/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-12-12 19:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-12-12 19:22:05]

On 2016/12/12 16:29:31, Tom Sepez wrote:
> On 2016/12/10 01:21:41, Ken Rockot wrote:
> > lgtm
> 
> When swapping "conectors" and "connectees", so to speak, the issue is whether
> there is a possibility for impersonation that didn't previously exist.  How
does
> ash know that it's really chrome that's registering with it?

This is a good question, but I certainly don't have an answer...

[msw, 2016-12-12 22:06:56]

On 2016/12/12 16:29:31, Tom Sepez wrote:
> When swapping "conectors" and "connectees", so to speak, the issue is whether
> there is a possibility for impersonation that didn't previously exist.  How
does
> ash know that it's really chrome that's registering with it?

As discussed offline, access to the 'ash' class of interfaces is restricted by
explicitly granted permissions in the manifest files. Some other approved
service:ash client might set itself as the presenter, but we control the set of
clients, and shouldn't approve any bad users that impersonate chrome. Currently,
Chrome (content_browser) and mash_unittests are the only services that access
ash. I hope that covers your concern, thanks!

[Tom Sepez, 2016-12-12 22:12:04]

lgtm

[commit-bot: I haz the power, 2016-12-12 22:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 22:23:23]

Failed to apply patch for ash/common/mojo_interface_factory.cc:
While running git apply --index -p1;
  error: patch failed: ash/common/mojo_interface_factory.cc:10
  error: ash/common/mojo_interface_factory.cc: patch does not apply

Patch:       ash/common/mojo_interface_factory.cc
Index: ash/common/mojo_interface_factory.cc
diff --git a/ash/common/mojo_interface_factory.cc
b/ash/common/mojo_interface_factory.cc
index
ef0b47f774cee1364c4553741be7a808205622ae..27967024621a94ef4cd4d794de4561e6f94cd923
100644
--- a/ash/common/mojo_interface_factory.cc
+++ b/ash/common/mojo_interface_factory.cc
@@ -10,6 +10,7 @@
 #include "ash/common/cast_config_controller.h"
 #include "ash/common/new_window_controller.h"
 #include "ash/common/shelf/shelf_controller.h"
+#include "ash/common/shell_delegate.h"
 #include "ash/common/shutdown_controller.h"
 #include "ash/common/system/locale/locale_notification_controller.h"
 #include "ash/common/system/tray/system_tray_controller.h"
@@ -18,6 +19,7 @@
 #include "ash/common/wm_shell.h"
 #include "base/bind.h"
 #include "services/service_manager/public/cpp/interface_registry.h"
+#include "ui/app_list/presenter/app_list.h"
 
 #if defined(OS_CHROMEOS)
 #include "ash/common/system/chromeos/network/vpn_list.h"
@@ -32,6 +34,10 @@ void BindAcceleratorControllerRequestOnMainThread(
   WmShell::Get()->accelerator_controller()->BindRequest(std::move(request));
 }
 
+void BindAppListRequestOnMainThread(app_list::mojom::AppListRequest request) {
+  WmShell::Get()->app_list()->BindRequest(std::move(request));
+}
+
 void BindCastConfigOnMainThread(mojom::CastConfigRequest request) {
   WmShell::Get()->cast_config()->BindRequest(std::move(request));
 }
@@ -85,6 +91,8 @@ void RegisterInterfaces(
   registry->AddInterface(
       base::Bind(&BindAcceleratorControllerRequestOnMainThread),
       main_thread_task_runner);
+  registry->AddInterface(base::Bind(&BindAppListRequestOnMainThread),
+                         main_thread_task_runner);
   registry->AddInterface(base::Bind(&BindCastConfigOnMainThread),
                          main_thread_task_runner);
   registry->AddInterface(

[msw, 2016-12-12 22:52:18]

The CQ bit was checked by msw@chromium.org

[msw, 2016-12-12 22:52:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, jamescook@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2567523002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-12 22:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2016-12-12 22:59:39]

LGTM with a couple nits

[mfomitchev, 2016-12-12 22:59:50]

https://codereview.chromium.org/2567523002/diff/60001/ash/mus/app_list_presen...
File ash/mus/app_list_presenter_mus.cc (right):

https://codereview.chromium.org/2567523002/diff/60001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:17: app_list::AppList* app_list =
WmShell::Get()->app_list();
nit: why not do 
app_list_presenter = WmShell::Get()->app_list()->GetAppListPresenter()
here and below

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/B...
File ui/app_list/presenter/BUILD.gn (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/B...
ui/app_list/presenter/BUILD.gn:19: export_class_attribute =
"APP_LIST_PRESENTER_EXPORT"
Cool. Are these new in mojo? Are they actually necessary for this to work
properly?

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
File ui/app_list/presenter/app_list.h (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
ui/app_list/presenter/app_list.h:14: // Interface for setting the app list
presenter.
Maybe something like this?
Exposes interface for setting app list presenter. Stores the interface pointer
for later use by whoever needs it.

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
File ui/app_list/presenter/app_list_presenter.mojom (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
ui/app_list/presenter/app_list_presenter.mojom:14: interface AppList {
nit: It would be nice to have a name which would convey the purpose of this
interface a little better. AppListProxy? AppListBinder? AppListBinding?
AppListController (although that could be confusing, since we already have one)?
Would be nice to have consistent naming with the other cases we have a similar
design though (volume/wallpaper/etc), so perhaps something to consider for a
future CL.

[msw, 2016-12-12 23:47:54]

Thanks for the review.

https://codereview.chromium.org/2567523002/diff/60001/ash/mus/app_list_presen...
File ash/mus/app_list_presenter_mus.cc (right):

https://codereview.chromium.org/2567523002/diff/60001/ash/mus/app_list_presen...
ash/mus/app_list_presenter_mus.cc:17: app_list::AppList* app_list =
WmShell::Get()->app_list();
On 2016/12/12 22:59:49, mfomitchev wrote:
> nit: why not do 
> app_list_presenter = WmShell::Get()->app_list()->GetAppListPresenter()
> here and below

Done.

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/B...
File ui/app_list/presenter/BUILD.gn (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/B...
ui/app_list/presenter/BUILD.gn:19: export_class_attribute =
"APP_LIST_PRESENTER_EXPORT"
On 2016/12/12 22:59:49, mfomitchev wrote:
> Cool. Are these new in mojo? Are they actually necessary for this to work
> properly?

I don't know how new they are; but they fixed my component build; which
otherwise failed to export the interface to targets that include the 'presenter'
component target below (despite the inclusion of this target in its
public_deps). Yuzhu helped me with this; thanks Yuzhu!

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
File ui/app_list/presenter/app_list.h (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
ui/app_list/presenter/app_list.h:14: // Interface for setting the app list
presenter.
On 2016/12/12 22:59:50, mfomitchev wrote:
> Maybe something like this?
> Exposes interface for setting app list presenter. Stores the interface pointer
> for later use by whoever needs it.

I went with "// Stores the app list presenter interface pointer."

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
File ui/app_list/presenter/app_list_presenter.mojom (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/a...
ui/app_list/presenter/app_list_presenter.mojom:14: interface AppList {
On 2016/12/12 22:59:50, mfomitchev wrote:
> nit: It would be nice to have a name which would convey the purpose of this
> interface a little better. AppListProxy? AppListBinder? AppListBinding?
> AppListController (although that could be confusing, since we already have
one)?
> Would be nice to have consistent naming with the other cases we have a similar
> design though (volume/wallpaper/etc), so perhaps something to consider for a
> future CL.

This could be 'AppListPresenterHost', but that just reinforces the existing
complexity and doesn't convey anything terribly useful to casual readers. It
would be more appropriate to call this interface "AppListClient" and rename
"AppListPresenter" to "AppList".

Regardless, ash should ultimately own the app list interface and Chrome should
just inject some app info (similar to what we want for the shelf, see TODO
above), so I'd rather not spend too much effort on naming here.

[msw, 2016-12-12 23:47:59]

The CQ bit was checked by msw@chromium.org

[msw, 2016-12-12 23:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, jamescook@chromium.org, mfomitchev@chromium.org,
xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2567523002/#ps100001
(title: "Address comments,")

[commit-bot: I haz the power, 2016-12-12 23:48:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2016-12-13 01:14:13]

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/B...
File ui/app_list/presenter/BUILD.gn (right):

https://codereview.chromium.org/2567523002/diff/60001/ui/app_list/presenter/B...
ui/app_list/presenter/BUILD.gn:19: export_class_attribute =
"APP_LIST_PRESENTER_EXPORT"
On 2016/12/12 23:47:54, msw wrote:
> On 2016/12/12 22:59:49, mfomitchev wrote:
> > Cool. Are these new in mojo? Are they actually necessary for this to work
> > properly?
> 
> I don't know how new they are; but they fixed my component build; which
> otherwise failed to export the interface to targets that include the
'presenter'
> component target below (despite the inclusion of this target in its
> public_deps). Yuzhu helped me with this; thanks Yuzhu!

Thanks for the explanation.

[commit-bot: I haz the power, 2016-12-13 01:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:46:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-12-13 02:16:10]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:51:28]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481595370779910,
"parent_rev": "d4382f7cab2bce2d8d552cb171ab9faba976e502", "commit_rev":
"82e4fd0520cd68c843125b868f5e4fbaa876ef50"}

[commit-bot: I haz the power, 2016-12-13 03:51:54]

Description was changed from

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chrom...
==========

to

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chrom...

Review-Url: https://codereview.chromium.org/2567523002
==========

[commit-bot: I haz the power, 2016-12-13 03:51:55]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-13 03:54:58]

Description was changed from

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chrom...

Review-Url: https://codereview.chromium.org/2567523002
==========

to

==========
mash: Have chrome set itself as the app list presenter.

Do not let ash connect to chrome to get the presenter.

Expose mojom::AppList interface in ash to set the presenter.
Chrome's AppListPresenterService connects to register.
Move instance from Chrome's FactoryImpl to AppListServiceAsh.

Implement app_list::AppList; owned by ash::WmShell.

Add export info to app_list's 'presenter' component.
(lets it add the mojom as a public DEPS; thanks Yuzhu!)

Remove connection and interface pointer from AppListPresenterMus.

TODO: What's not TODO here? It's a mess!

BUG=670775
TEST=No regressions in chrome --mash app list behavior
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,rockot@chrom...

Committed: https://crrev.com/982c17a70a9c06b191b96e6e77f78933d0989de4
Cr-Commit-Position: refs/heads/master@{#438044}
==========

[commit-bot: I haz the power, 2016-12-13 03:55:00]

Patchset 6 (id:??) landed as
https://crrev.com/982c17a70a9c06b191b96e6e77f78933d0989de4
Cr-Commit-Position: refs/heads/master@{#438044}