Replace CFX_FloatArray with std::vector

Replace CFX_FloatArray with std::vector

Review-Url: https://codereview.chromium.org/2567503002
Committed: https://pdfium.googlesource.com/pdfium/+/988599c5d81bbb568f949454580ec6001258f806

[Tom Sepez, 2016-12-09 01:06:29]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 01:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:11:09]

Dry run: Try jobs failed on following builders:
  win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/b...)

[Tom Sepez, 2016-12-13 17:39:35]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 17:39:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-13 17:40:09]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-13 17:40:10]

Dan, ready for review.

[commit-bot: I haz the power, 2016-12-13 17:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:55:09]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-13 18:27:21]

https://codereview.chromium.org/2567503002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidgetacc.cpp (right):

https://codereview.chromium.org/2567503002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidgetacc.cpp:130: std::unique_ptr<std::vector<FX_FLOAT>>
m_pFieldSplitArray;
Does this still need to be a unique_ptr?

[Tom Sepez, 2016-12-13 19:10:48]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 19:10:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-13 19:11:01]

https://codereview.chromium.org/2567503002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidgetacc.cpp (right):

https://codereview.chromium.org/2567503002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidgetacc.cpp:130: std::unique_ptr<std::vector<FX_FLOAT>>
m_pFieldSplitArray;
On 2016/12/13 18:27:21, dsinclair wrote:
> Does this still need to be a unique_ptr?

Probably not.  An empty std::vector<> doesn't take a lot of resources. done.

[commit-bot: I haz the power, 2016-12-13 19:33:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:33:31]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-13 20:45:37]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-13 20:45:37]

lgtm

[commit-bot: I haz the power, 2016-12-13 20:45:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:45:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481661937250600,
"parent_rev": "05b4fc1227f5b6d39a3a65daf915a92ea3b749f4", "commit_rev":
"988599c5d81bbb568f949454580ec6001258f806"}

[commit-bot: I haz the power, 2016-12-13 20:45:59]

Description was changed from

==========
Replace CFX_FloatArray with std::vector
==========

to

==========
Replace CFX_FloatArray with std::vector

Review-Url: https://codereview.chromium.org/2567503002
Committed:
https://pdfium.googlesource.com/pdfium/+/988599c5d81bbb568f949454580ec6001258...
==========

[commit-bot: I haz the power, 2016-12-13 20:46:00]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/988599c5d81bbb568f949454580ec6001258...