Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 25675011: pdf: drawPath should pass the computed matrix, instead of default matrix stored in draw. (Closed)

Created:
7 years, 2 months ago by edisonn
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

pdf: drawPath should pass the computed matrix, instead of default matrix stored in draw. moved cl https://codereview.chromium.org/24265006/ in git repository so I can run the trybots R=vandebo@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=11626

Patch Set 1 #

Patch Set 2 : handleinvert too #

Patch Set 3 : fix typo #

Total comments: 2

Patch Set 4 : pass the right matrix #

Patch Set 5 : just re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M include/pdf/SkPDFDevice.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
edisonn
7 years, 2 months ago (2013-10-04 17:28:52 UTC) #1
vandebo (ex-Chrome)
https://codereview.chromium.org/25675011/diff/9001/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/25675011/diff/9001/src/pdf/SkPDFDevice.cpp#newcode1542 src/pdf/SkPDFDevice.cpp:1542: drawPath(d, modifiedPath, noInversePaint, &totalMatrix, true); Shouldn't this be the ...
7 years, 2 months ago (2013-10-04 18:40:21 UTC) #2
edisonn
https://codereview.chromium.org/25675011/diff/9001/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/25675011/diff/9001/src/pdf/SkPDFDevice.cpp#newcode1542 src/pdf/SkPDFDevice.cpp:1542: drawPath(d, modifiedPath, noInversePaint, &totalMatrix, true); On 2013/10/04 18:40:21, vandebo ...
7 years, 2 months ago (2013-10-04 18:46:23 UTC) #3
vandebo (ex-Chrome)
LGTM
7 years, 2 months ago (2013-10-04 20:30:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/25675011/14001
7 years, 2 months ago (2013-10-04 21:03:43 UTC) #5
commit-bot: I haz the power
Presubmit check for 25675011-14001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-04 21:03:46 UTC) #6
edisonn
** Presubmit ERRORS ** Since the CL is editing public API, you must have an ...
7 years, 2 months ago (2013-10-04 21:05:46 UTC) #7
edisonn
7 years, 2 months ago (2013-10-07 13:22:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r11626.

Powered by Google App Engine
This is Rietveld 408576698