Issue 24265006: pdf: drawPath should pass the computed matrix, instead of default matrix stored in draw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24265006: pdf: drawPath should pass the computed matrix, instead of default matrix stored in draw. (Closed)

Created:
7 years, 3 months ago by edisonn

Modified:
7 years, 2 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pdf: drawPath should pass the computed matrix, instead of default matrix stored in draw.

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View	1	4 chunks	+8 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

edisonn

fix the bug I noticed during implementing perspective for pdf

7 years, 3 months ago (2013-09-20 18:04:20 UTC) #1

vandebo (ex-Chrome)

7 years, 3 months ago (2013-09-20 18:57:56 UTC) #2

https://codereview.chromium.org/24265006/diff/4001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/24265006/diff/4001/src/pdf/SkPDFDevice.cpp#ne...
src/pdf/SkPDFDevice.cpp:1419: drawPath(d, modifiedPath, noInversePaint, matrix,
true);
This isn't the prePathMatrix, this is the total matrix.  Given the interface
here, it's probably best to just pass the prePathMatrix intohandleInversePath
and recalculate the total matrix.... or to pass all of d, the total matrix, and
the prePathMatrix...

Expand Messages | Collapse Messages