Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2567493002: Remove two SpdySessionPoolPeer methods. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove two SpdySessionPoolPeer methods. Remove SpdySessionPoolPeer::SetSessionMaxRecvWindowSize() and SpdySessionPoolPeer::SetStreamInitialRecvWindowSize(): |session_deps_| has corresponding members and is more widely used in tests, so use them instead. BUG=622737 Committed: https://crrev.com/903e8c18c8722819356c5f161b08672226651ee8 Cr-Commit-Position: refs/heads/master@{#437639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Bence
Ryan: PTAL.
4 years ago (2016-12-09 01:33:56 UTC) #7
Bence
Ryan: PTAL.
4 years ago (2016-12-09 01:33:56 UTC) #8
Ryan Hamilton
This CL doesn't actually remove methods from SpdySessionPool. Is the CL description wrong, or are ...
4 years ago (2016-12-09 17:26:50 UTC) #10
Bence
The description was incorrect: I am removing SpdySessionPoolPeer methods. My apologies.
4 years ago (2016-12-09 17:35:59 UTC) #12
Ryan Hamilton
lgtm
4 years ago (2016-12-09 19:40:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567493002/1
4 years ago (2016-12-09 19:40:53 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:50:40 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:21 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/903e8c18c8722819356c5f161b08672226651ee8
Cr-Commit-Position: refs/heads/master@{#437639}

Powered by Google App Engine
This is Rietveld 408576698