[New Multicolumn] Make offsetLeft, offsetTop and getClientRects() behave.

[New Multicolumn] Make offsetLeft, offsetTop and getClientRects() behave.

Get rid of mapFromFlowToRegion() and mapLocalToContainer() in
RenderFlowThread, and reimplement columnOffset() in
RenderMultiColumnFlowThread instead. This method is already used a lot
in the engine, but it has up until now only worked with the old multicol
implementation. Need to add a call from
RenderBox::offsetFromContainer(), since the one that's already there
is for old multicol only and does special stuff.

This incidentally also gets rid of assertion failures in
RenderGeometryMap when compositing is turned on (what used to be in
RenderFlowThread::mapLocalToContainer() did the wrong thing if the
target was that flow thread itself). Re-enable tests that used to
fail on that assertion.

BUG=367688, 364960
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172961

[ojan, 2014-04-30 02:13:13]

lgtm

[commit-bot: I haz the power, 2014-04-30 02:13:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/256743006/1

[commit-bot: I haz the power, 2014-04-30 02:14:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 02:14:05]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 949.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
a14e15e37e9a408a188517cf174cbec7fa040b48..9358bf63a61e0d68c3859f1bcb88b517e36c7474
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -949,11 +949,6 @@ crbug.com/359960 compositing/iframes/scrolling-iframe.html
[ Pass Failure ]
 crbug.com/359960 virtual/softwarecompositing/iframes/scrolling-iframe.html [
Pass Failure ]
 crbug.com/359961 inspector/timeline/timeline-window-filter.html [ Pass Timeout
]
 
-# These tests don't work when force compositing mode is enabled.
-crbug.com/364960 fast/multicol/newmulticol/hide-box-horizontal-bt.html [ Skip ]
-crbug.com/364960 fast/multicol/newmulticol/hide-box-vertical-rl.html [ Skip ]
-crbug.com/364960 fast/multicol/newmulticol/layers-in-multicol.html [ Skip ]
-
 # Flaky on debug
 crbug.com/356780 [ Win ]
virtual/windows-directwrite/fast/text/sub-pixel/text-scaling-pixel.html [ Pass
ImageOnlyFailure Failure ]

[mstensho (USE GERRIT), 2014-04-30 07:15:49]

Rebase master

[mstensho (USE GERRIT), 2014-04-30 07:16:53]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-04-30 07:17:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/256743006/20001

[commit-bot: I haz the power, 2014-04-30 08:26:08]

Change committed as 172961