Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256743005: Add removeAll method to sets and maps and use them (Closed)

Created:
6 years, 8 months ago by Erik Corry
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, fs, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, ojan, blink-layers+watch_chromium.org, chrishtr, krit, bemjb+rendering_chromium.org, malch+blink_chromium.org, dsinclair, rwlbuis, yurys+blink_chromium.org, abarth-chromium, danakj, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rune+blink, loislo+blink_chromium.org, zoltan1, sof, caseq+blink_chromium.org, lushnikov+blink_chromium.org, jbroman, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, Nate Chapin, alph+blink_chromium.org, kouhei+svg_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, Mikhail
Visibility:
Public.

Description

Add removeAll method to sets and maps and use them R=jochen@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172637

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved implementation of removeAll to HashTable.h and shared it. Also added it to LinkedHashSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -37 lines) Patch
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fetch/ResourceLoadPriorityOptimizer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/web/AssociatedURLLoader.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/wtf/HashMap.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/HashSet.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/HashTable.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/wtf/LinkedHashSet.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/ListHashSet.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/text/TextEncodingRegistry.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Erik Corry
6 years, 8 months ago (2014-04-25 10:48:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-25 10:51:49 UTC) #2
wibling-chromium
lgtm
6 years, 8 months ago (2014-04-25 10:56:17 UTC) #3
Mikhail
https://codereview.chromium.org/256743005/diff/1/Source/wtf/HashMap.h File Source/wtf/HashMap.h (right): https://codereview.chromium.org/256743005/diff/1/Source/wtf/HashMap.h#newcode418 Source/wtf/HashMap.h:418: inline void HashMap<T, U, V, W, X, Y>::removeAll(const Collection& ...
6 years, 8 months ago (2014-04-25 11:02:26 UTC) #4
Erik Corry
https://codereview.chromium.org/256743005/diff/1/Source/wtf/HashMap.h File Source/wtf/HashMap.h (right): https://codereview.chromium.org/256743005/diff/1/Source/wtf/HashMap.h#newcode418 Source/wtf/HashMap.h:418: inline void HashMap<T, U, V, W, X, Y>::removeAll(const Collection& ...
6 years, 8 months ago (2014-04-25 12:00:30 UTC) #5
Mikhail
LGTM
6 years, 8 months ago (2014-04-25 12:06:02 UTC) #6
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 8 months ago (2014-04-25 12:10:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/256743005/20001
6 years, 8 months ago (2014-04-25 12:10:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 13:00:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-25 13:00:15 UTC) #10
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 8 months ago (2014-04-25 13:04:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/256743005/20001
6 years, 8 months ago (2014-04-25 13:05:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 13:47:34 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-25 13:47:34 UTC) #14
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 8 months ago (2014-04-25 13:57:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/256743005/20001
6 years, 8 months ago (2014-04-25 13:58:37 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 14:57:19 UTC) #17
Message was sent while issue was closed. 
Change committed as 172637

Powered by Google App Engine
This is Rietveld 408576698