Source/core/rendering/RenderLayer.cpp - Issue 256743005: Add removeAll method to sets and maps and use them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 256743005: Add removeAll method to sets and maps and use them (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Moved implementation of removeAll to HashTable.h and shared it. Also added it to LinkedHashSet Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index 38bee73e188cdd699e261750bcef033148c7c557..c3082e0b9b264e2da1e80119e0752eda43a69790 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -1854,8 +1854,7 @@ static void performOverlapTests(OverlapTestRequestMap& overlapTestRequests, cons

it->key->setIsOverlapped(true);

overlappedRequestClients.append(it->key);

}

- for (size_t i = 0; i < overlappedRequestClients.size(); ++i)

- overlapTestRequests.remove(overlappedRequestClients[i]);

+ overlapTestRequests.removeAll(overlappedRequestClients);

}

static bool shouldDoSoftwarePaint(const RenderLayer* layer, bool paintingReflection)