Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2567393003:
[Chromecast] Fix for building Android Cast builds with virtualenv. (Closed)
Description[Chromecast] Fix for building Android Cast builds with virtualenv.
The Chromecast CQ bots are failing to build the Android builds.
Iterating over sys.modules with itervalues() results in a runtime error
because sys.modules is apparently changing size. Using
sys.modules.values() instead lets sys.modules change without a runtime
error since it makes a copy.
BUG=673915
Committed: https://crrev.com/d00168a948a32f378a0c05842ee52ca35905c9d5
Cr-Commit-Position: refs/heads/master@{#439234}
Patch Set 1 #Patch Set 2 : Better describe the root cause of the issue #
Total comments: 1
Patch Set 3 : Ensure sys.modules is stabilized before getting the final list of modules. #Messages
Total messages: 19 (8 generated)
mbjorge@chromium.org changed reviewers: + agrieve@chromium.org, slan@chromium.org
lgtm
https://codereview.chromium.org/2567393003/diff/20001/build/android/gyp/util/... File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/2567393003/diff/20001/build/android/gyp/util/... build/android/gyp/util/build_utils.py:412: module_paths = (m.__file__ for m in sys.modules.values() If it's being updated during iteration, then we're probably missing some modules now. Maybe change this to a loop that exits once the list of modules has stabilized?
On 2016/12/14 at 15:35:28, agrieve wrote: > https://codereview.chromium.org/2567393003/diff/20001/build/android/gyp/util/... > File build/android/gyp/util/build_utils.py (right): > > https://codereview.chromium.org/2567393003/diff/20001/build/android/gyp/util/... > build/android/gyp/util/build_utils.py:412: module_paths = (m.__file__ for m in sys.modules.values() > If it's being updated during iteration, then we're probably missing some modules now. > > Maybe change this to a loop that exits once the list of modules has stabilized? Done
friendly ping!
On 2016/12/15 21:20:34, mbjorge wrote: > friendly ping! sorry, lgtm!
The CQ bit was checked by mbjorge@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from slan@chromium.org Link to the patchset: https://codereview.chromium.org/2567393003/#ps40001 (title: "Ensure sys.modules is stabilized before getting the final list of modules.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by mbjorge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481927337876390,
"parent_rev": "6c3afb724fe9bfefa1a37cde751a0d040d42942b", "commit_rev":
"804296739a7f4a83eae974be853b9d0fafd5de68"}
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Fix for building Android Cast builds with virtualenv. The Chromecast CQ bots are failing to build the Android builds. Iterating over sys.modules with itervalues() results in a runtime error because sys.modules is apparently changing size. Using sys.modules.values() instead lets sys.modules change without a runtime error since it makes a copy. BUG=673915 ========== to ========== [Chromecast] Fix for building Android Cast builds with virtualenv. The Chromecast CQ bots are failing to build the Android builds. Iterating over sys.modules with itervalues() results in a runtime error because sys.modules is apparently changing size. Using sys.modules.values() instead lets sys.modules change without a runtime error since it makes a copy. BUG=673915 Review-Url: https://codereview.chromium.org/2567393003 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Fix for building Android Cast builds with virtualenv. The Chromecast CQ bots are failing to build the Android builds. Iterating over sys.modules with itervalues() results in a runtime error because sys.modules is apparently changing size. Using sys.modules.values() instead lets sys.modules change without a runtime error since it makes a copy. BUG=673915 Review-Url: https://codereview.chromium.org/2567393003 ========== to ========== [Chromecast] Fix for building Android Cast builds with virtualenv. The Chromecast CQ bots are failing to build the Android builds. Iterating over sys.modules with itervalues() results in a runtime error because sys.modules is apparently changing size. Using sys.modules.values() instead lets sys.modules change without a runtime error since it makes a copy. BUG=673915 Committed: https://crrev.com/d00168a948a32f378a0c05842ee52ca35905c9d5 Cr-Commit-Position: refs/heads/master@{#439234} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d00168a948a32f378a0c05842ee52ca35905c9d5 Cr-Commit-Position: refs/heads/master@{#439234} |
