Removed DCHECK in ConnectionLoginFailed which was being hit on iOS

Removed DCHECK in ConnectionLoginFailed which was being hit on iOS

Removed a DCHECK which was being hit. The code should recover from the
condition without issues. Added a TODO to investigate why the code is
able to reach this point without SUCCESSFUL_CONNECTION being set.

BUG=673706
Committed: https://crrev.com/0a229a880d7e5ce16eaa6e796fac2164dbb475db
Cr-Commit-Position: refs/heads/master@{#438479}

[harkness, 2016-12-13 12:21:12]

harkness@chromium.org changed reviewers:
+ peter@chromium.org, zea@chromium.org

[harkness, 2016-12-13 12:21:13]

This DCHECK was being hit so I temporarily disabled it.

[Peter Beverloo, 2016-12-13 13:38:26]

lgtm, but please prioritize finding out why this fails since it means we may be
collecting invalid data. (Either we skip recording the successful connection
part, we fail login after failing connection or multiple connections are in
flight.)

[Nicolas Zea, 2016-12-13 20:25:12]

lgtm

[harkness, 2016-12-14 10:25:31]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-12-14 10:25:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 11:16:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481711131477280, "parent_rev":
"208727b67a0e9d2985617cea070fb9787e680311", "commit_rev":
"042b7d4194d4e0ea47d065f55e3aac75f8577825"}

[commit-bot: I haz the power, 2016-12-14 11:17:15]

Description was changed from

==========
Removed DCHECK in ConnectionLoginFailed which was being hit on iOS

Removed a DCHECK which was being hit. The code should recover from the
condition without issues. Added a TODO to investigate why the code is
able to reach this point without SUCCESSFUL_CONNECTION being set.

BUG=673706
==========

to

==========
Removed DCHECK in ConnectionLoginFailed which was being hit on iOS

Removed a DCHECK which was being hit. The code should recover from the
condition without issues. Added a TODO to investigate why the code is
able to reach this point without SUCCESSFUL_CONNECTION being set.

BUG=673706

Review-Url: https://codereview.chromium.org/2567373002
==========

[commit-bot: I haz the power, 2016-12-14 11:17:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 11:20:47]

Description was changed from

==========
Removed DCHECK in ConnectionLoginFailed which was being hit on iOS

Removed a DCHECK which was being hit. The code should recover from the
condition without issues. Added a TODO to investigate why the code is
able to reach this point without SUCCESSFUL_CONNECTION being set.

BUG=673706

Review-Url: https://codereview.chromium.org/2567373002
==========

to

==========
Removed DCHECK in ConnectionLoginFailed which was being hit on iOS

Removed a DCHECK which was being hit. The code should recover from the
condition without issues. Added a TODO to investigate why the code is
able to reach this point without SUCCESSFUL_CONNECTION being set.

BUG=673706

Committed: https://crrev.com/0a229a880d7e5ce16eaa6e796fac2164dbb475db
Cr-Commit-Position: refs/heads/master@{#438479}
==========

[commit-bot: I haz the power, 2016-12-14 11:20:47]

Patchset 1 (id:??) landed as
https://crrev.com/0a229a880d7e5ce16eaa6e796fac2164dbb475db
Cr-Commit-Position: refs/heads/master@{#438479}