Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2567353002: Revert of [heap] Enable black allocation when finalizing marking. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Enable black allocation when finalizing marking. (patchset #3 id:40001 of https://codereview.chromium.org/2440943002/ ) Reason for revert: Seems to block roll: https://codereview.chromium.org/2569133002/ Original issue's description: > [heap] Enable black allocation when finalizing marking. > > BUG=chromium:630386 > > Committed: https://crrev.com/a98d971412a5c32967bbef4b77b9d2658055ff1c > Cr-Commit-Position: refs/heads/master@{#41655} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630386 Committed: https://crrev.com/cd23d6771a04057d19dc326e73bef72abd318a34 Cr-Commit-Position: refs/heads/master@{#41665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [heap] Enable black allocation when finalizing marking.
4 years ago (2016-12-13 09:39:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567353002/1
4 years ago (2016-12-13 09:39:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 09:40:10 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 09:41:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd23d6771a04057d19dc326e73bef72abd318a34
Cr-Commit-Position: refs/heads/master@{#41665}

Powered by Google App Engine
This is Rietveld 408576698