Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2567343004: [parser] Fix bug with non-static name method/property (Closed)

Created:
4 years ago by nickie
Modified:
4 years ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Fix bug with non-static name method/property Without this patch, the tests on lines 410, 414, 418 and 422 in function testNonStaticName of test/mjsunit/es6/function-name.js would all fail. The bug caused non-static "name" methods and properties to be mistaken for static ones. R=adamk@chromium.org, verwaest@chromium.org BUG= LOG=N Committed: https://crrev.com/f39665e36086361a1643d7c43b147bc3894a3bca Cr-Commit-Position: refs/heads/master@{#41692}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/parsing/parser-base.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/function-name.js View 1 chunk +36 lines, -0 lines 1 comment Download

Messages

Total messages: 18 (12 generated)
nickie
4 years ago (2016-12-13 22:12:42 UTC) #1
nickie
https://codereview.chromium.org/2567343004/diff/1/test/mjsunit/es6/function-name.js File test/mjsunit/es6/function-name.js (right): https://codereview.chromium.org/2567343004/diff/1/test/mjsunit/es6/function-name.js#newcode389 test/mjsunit/es6/function-name.js:389: Guys, please check that these two sets of tests ...
4 years ago (2016-12-13 22:14:44 UTC) #2
adamk
lgtm, thanks for the fix!
4 years ago (2016-12-14 07:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567343004/1
4 years ago (2016-12-14 12:09:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 12:11:22 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-14 12:12:05 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f39665e36086361a1643d7c43b147bc3894a3bca
Cr-Commit-Position: refs/heads/master@{#41692}

Powered by Google App Engine
This is Rietveld 408576698