Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by nickie Modified:
4 years ago Reviewers:
adamk, Toon Verwaest CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[parser] Fix bug with non-static name method/property
Without this patch, the tests on lines 410, 414, 418 and 422 in
function testNonStaticName of test/mjsunit/es6/function-name.js
would all fail. The bug caused non-static "name" methods and
properties to be mistaken for static ones.
R=adamk@chromium.org, verwaest@chromium.org
BUG=
LOG=N
Committed: https://crrev.com/f39665e36086361a1643d7c43b147bc3894a3bca
Cr-Commit-Position: refs/heads/master@{#41692}
Patch Set 1 #
Total comments: 1
Created: 4 years ago
Messages
Total messages: 18 (12 generated)
https://codereview.chromium.org/2567343004/diff/1/test/mjsunit/es6/function-n... File test/mjsunit/es6/function-name.js (right): https://codereview.chromium.org/2567343004/diff/1/test/mjsunit/es6/function-n... test/mjsunit/es6/function-name.js:389: Guys, please check that these two sets of tests actually make sense. I won't pretend I know what this damned property is... :-)
lgtm, thanks for the fix!
The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: The author nikolaos@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nikolaos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481717354424320, "parent_rev":
"5b1f936d139c5c5e6d68f6d7d40127c13ec539d6", "commit_rev":
"e625be69866dc5b1d1da1aa0217bd769a56d2b3f"}
Message was sent while issue was closed.
Description was changed from ========== [parser] Fix bug with non-static name method/property Without this patch, the tests on lines 410, 414, 418 and 422 in function testNonStaticName of test/mjsunit/es6/function-name.js would all fail. The bug caused non-static "name" methods and properties to be mistaken for static ones. R=adamk@chromium.org, verwaest@chromium.org BUG= LOG=N ========== to ========== [parser] Fix bug with non-static name method/property Without this patch, the tests on lines 410, 414, 418 and 422 in function testNonStaticName of test/mjsunit/es6/function-name.js would all fail. The bug caused non-static "name" methods and properties to be mistaken for static ones. R=adamk@chromium.org, verwaest@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2567343004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [parser] Fix bug with non-static name method/property Without this patch, the tests on lines 410, 414, 418 and 422 in function testNonStaticName of test/mjsunit/es6/function-name.js would all fail. The bug caused non-static "name" methods and properties to be mistaken for static ones. R=adamk@chromium.org, verwaest@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2567343004 ========== to ========== [parser] Fix bug with non-static name method/property Without this patch, the tests on lines 410, 414, 418 and 422 in function testNonStaticName of test/mjsunit/es6/function-name.js would all fail. The bug caused non-static "name" methods and properties to be mistaken for static ones. R=adamk@chromium.org, verwaest@chromium.org BUG= LOG=N Committed: https://crrev.com/f39665e36086361a1643d7c43b147bc3894a3bca Cr-Commit-Position: refs/heads/master@{#41692} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f39665e36086361a1643d7c43b147bc3894a3bca Cr-Commit-Position: refs/heads/master@{#41692} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
