Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2567303003: [ios] Removed unused CRWWebControllerObserver methods. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed unused CRWWebControllerObserver methods. Removed |handleCommand:webController:userIsInteracting:originURL:| and |commandPrefix| methods. BUG=616244 Committed: https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233 Cr-Commit-Position: refs/heads/master@{#438331}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -245 lines) Patch
M ios/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/public/web_state/crw_web_controller_observer.h View 3 chunks +0 lines, -20 lines 0 comments Download
M ios/web/test/crw_fake_web_controller_observer.h View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/web/test/crw_fake_web_controller_observer.mm View 1 chunk +1 line, -38 lines 0 comments Download
D ios/web/test/crw_fake_web_controller_observer_unittest.mm View 1 chunk +0 lines, -54 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_observer_unittest.mm View 1 3 chunks +2 lines, -49 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 3 chunks +0 lines, -27 lines 0 comments Download
M ios/web/web_state/web_controller_observer_bridge.h View 1 2 chunks +0 lines, -13 lines 0 comments Download
M ios/web/web_state/web_controller_observer_bridge.mm View 1 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-13 19:05:31 UTC) #3
kkhorimoto
lgtm
4 years ago (2016-12-13 21:51:58 UTC) #4
Eugene But (OOO till 7-30)
Thanks!
4 years ago (2016-12-13 21:59:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567303003/20001
4 years ago (2016-12-13 22:00:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 23:19:59 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 23:23:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c64e082dd44826a935ec54019cfd2ea794808233
Cr-Commit-Position: refs/heads/master@{#438331}

Powered by Google App Engine
This is Rietveld 408576698