Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 25673004: When cache is full delay flush until GrContext draw is finished (Closed)

Created:
7 years, 2 months ago by bsalomon
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

When cache is full delay flush until GrContext draw is finished Committed: http://code.google.com/p/skia/source/detail?r=11613

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rob's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M include/gpu/GrContext.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 14 chunks +35 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
Prior to this CL gm --gpuCacheSize 0 0 --config gpu reproduced the crash we're seeing ...
7 years, 2 months ago (2013-10-04 15:14:33 UTC) #1
robertphillips
lgtm + comment suggestion & question https://codereview.chromium.org/25673004/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/25673004/diff/1/include/gpu/GrContext.h#newcode879 include/gpu/GrContext.h:879: // This is ...
7 years, 2 months ago (2013-10-04 15:28:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/25673004/4001
7 years, 2 months ago (2013-10-04 16:13:42 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 16:24:02 UTC) #4
Message was sent while issue was closed.
Change committed as 11613

Powered by Google App Engine
This is Rietveld 408576698