Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by hajimehoshi Modified:
4 years ago Reviewers:
Mark Mentovai, lawrencewu CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a macro for SharedMemory::Share
SharedMemory::Share was introduced at crrev.com/2555483002 only on Mac
and not other platforms. This CL adds a macro to SharedMemory::Share
declaration to clarily that the function Share is available only on Mac.
BUG=671228
TEST=n/a
Committed: https://crrev.com/73172f9e94e5af7e23867506c9e5a9d6bc99c703
Cr-Commit-Position: refs/heads/master@{#438434}
Patch Set 1 #
Created: 4 years ago
Depends on Patchset: Messages
Total messages: 15 (9 generated)
The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hajimehoshi@chromium.org changed reviewers: + lawrencewu@chromium.org, mark@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
lgtm
The CQ bit was checked by hajimehoshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481691225249840, "parent_rev":
"f671d9d18600d54c922796e43a875560a1e43a50", "commit_rev":
"3cc1a660f81a89f2401a65df6fe167b8d5a13804"}
Message was sent while issue was closed.
Description was changed from ========== Add a macro for SharedMemory::Share SharedMemory::Share was introduced at crrev.com/2555483002 only on Mac and not other platforms. This CL adds a macro to SharedMemory::Share declaration to clarily that the function Share is available only on Mac. BUG=671228 TEST=n/a ========== to ========== Add a macro for SharedMemory::Share SharedMemory::Share was introduced at crrev.com/2555483002 only on Mac and not other platforms. This CL adds a macro to SharedMemory::Share declaration to clarily that the function Share is available only on Mac. BUG=671228 TEST=n/a Review-Url: https://codereview.chromium.org/2567293003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add a macro for SharedMemory::Share SharedMemory::Share was introduced at crrev.com/2555483002 only on Mac and not other platforms. This CL adds a macro to SharedMemory::Share declaration to clarily that the function Share is available only on Mac. BUG=671228 TEST=n/a Review-Url: https://codereview.chromium.org/2567293003 ========== to ========== Add a macro for SharedMemory::Share SharedMemory::Share was introduced at crrev.com/2555483002 only on Mac and not other platforms. This CL adds a macro to SharedMemory::Share declaration to clarily that the function Share is available only on Mac. BUG=671228 TEST=n/a Committed: https://crrev.com/73172f9e94e5af7e23867506c9e5a9d6bc99c703 Cr-Commit-Position: refs/heads/master@{#438434} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/73172f9e94e5af7e23867506c9e5a9d6bc99c703 Cr-Commit-Position: refs/heads/master@{#438434} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
