Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2567263002: Fix Media Remoting Connector stream ID message parsing. (Closed)

Created:
4 years ago by miu
Modified:
4 years ago
Reviewers:
xjz
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, apacible+watch_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Media Remoting Connector stream ID message parsing. This fixes a bug where the 2nd arg to std::string::substr() was not the length, but the end position. Committed: https://crrev.com/6ec9ba0385703f6e96120355880cae613ffb2bae Cr-Commit-Position: refs/heads/master@{#438015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/media/cast_remoting_connector_messaging.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
miu
xjz: PTAL.
4 years ago (2016-12-13 01:21:26 UTC) #2
xjz
lgtm
4 years ago (2016-12-13 01:24:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567263002/1
4 years ago (2016-12-13 01:26:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 03:10:11 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-13 03:13:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ec9ba0385703f6e96120355880cae613ffb2bae
Cr-Commit-Position: refs/heads/master@{#438015}

Powered by Google App Engine
This is Rietveld 408576698