PlzNavigate: set browser_initiated based on the NavigationEntry

PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=

Committed: https://crrev.com/29e8c19b7b48ed4408fd761c2c573efd1d0ef943
Cr-Commit-Position: refs/heads/master@{#440637}

[clamy, 2016-12-14 15:51:20]

Description was changed from

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
==========

to

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-12-21 17:55:55]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 17:56:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:58:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[clamy, 2016-12-22 12:37:09]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 12:37:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 14:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 14:23:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2016-12-22 15:28:30]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 15:28:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-12-22 17:05:35]

Description was changed from

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-12-22 17:05:35]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-12-22 17:05:52]

@nasko: PTAL

[nasko, 2016-12-22 17:33:45]

LGTM with a couple of nits.

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_request.cc (right):

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_request.cc:219: // the renderer in the
first place.
nit: Let's include a clarification that LoadURL will be originated from the
renderer as part of OpenURL. As far as I know, there are no other paths causing
us to have renderer-initiated navigations coming through LoadURL.

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_request.h (right):

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_request.h:133: bool may_transfer() const {
return may_transfer_; }
nit: Using "can" vs "may" seems a bit more appropriate here. We want to check
whether this request is allowed to transfer (aka "can") not whether it might
possibly transfer (aka "may").

[clamy, 2016-12-22 17:37:40]

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_request.h (right):

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_request.h:133: bool may_transfer() const {
return may_transfer_; }
On 2016/12/22 17:33:45, nasko wrote:
> nit: Using "can" vs "may" seems a bit more appropriate here. We want to check
> whether this request is allowed to transfer (aka "can") not whether it might
> possibly transfer (aka "may").

I was worried that it might get confusing since its possible that may_transfer
is false, but we will still end up transferring it (old transfer navigation
case).

[nasko, 2016-12-22 17:45:35]

On 2016/12/22 17:37:40, clamy wrote:
>
https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
> File content/browser/frame_host/navigation_request.h (right):
> 
>
https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
> content/browser/frame_host/navigation_request.h:133: bool may_transfer() const
{
> return may_transfer_; }
> On 2016/12/22 17:33:45, nasko wrote:
> > nit: Using "can" vs "may" seems a bit more appropriate here. We want to
check
> > whether this request is allowed to transfer (aka "can") not whether it might
> > possibly transfer (aka "may").
> 
> I was worried that it might get confusing since its possible that may_transfer
> is false, but we will still end up transferring it (old transfer navigation
> case).

Ok, makes sense. Thanks!

[commit-bot: I haz the power, 2016-12-22 18:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 18:25:13]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[clamy, 2016-12-23 14:35:44]

Thanks!

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigation_request.cc (right):

https://codereview.chromium.org/2567253005/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigation_request.cc:219: // the renderer in the
first place.
On 2016/12/22 17:33:45, nasko wrote:
> nit: Let's include a clarification that LoadURL will be originated from the
> renderer as part of OpenURL. As far as I know, there are no other paths
causing
> us to have renderer-initiated navigations coming through LoadURL.

Done.

[clamy, 2016-12-23 14:35:51]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-12-23 14:35:51]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2567253005/#ps80001
(title: "Rebase + addressed comments")

[commit-bot: I haz the power, 2016-12-23 14:36:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2016-12-23 16:15:44]

The CQ bit was unchecked by clamy@chromium.org

[clamy, 2016-12-23 16:15:54]

Description was changed from

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
==========

[clamy, 2016-12-23 16:16:12]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2016-12-23 16:16:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 16:30:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482509772115730,
"parent_rev": "d464f13ed000e40e50b72539a08b7636254bfdbf", "commit_rev":
"6207acc1a9167514268764f244719660a16d4a46"}

[commit-bot: I haz the power, 2016-12-23 16:30:40]

Description was changed from

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=
==========

to

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=

Review-Url: https://codereview.chromium.org/2567253005
==========

[commit-bot: I haz the power, 2016-12-23 16:30:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-23 16:34:14]

Description was changed from

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=

Review-Url: https://codereview.chromium.org/2567253005
==========

to

==========
PlzNavigate: set browser_initiated based on the NavigationEntry

This CL ensures that NavigatioRequest::browser_initiated_ will be set
based on the NavigationEntry provided. Currently, all NavigationRequest
created following a call to Navigator:;LoadEntry are marked as
browser-initiated, but they could be renderer-initiated instead.

BUG=

Committed: https://crrev.com/29e8c19b7b48ed4408fd761c2c573efd1d0ef943
Cr-Commit-Position: refs/heads/master@{#440637}
==========

[commit-bot: I haz the power, 2016-12-23 16:34:15]

Patchset 5 (id:??) landed as
https://crrev.com/29e8c19b7b48ed4408fd761c2c573efd1d0ef943
Cr-Commit-Position: refs/heads/master@{#440637}