Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2567213002: Make list_files.py and list_dart_files.py return absolute paths for GN (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
Cutch, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make list_files.py and list_dart_files.py return absolute paths for GN This makes doing an SDK build in the Fuchsia tree easier. The previous attempt at this change failed in gyp builds targeting xcode. They failed because input lists for actions of the same target (e.g. the actions for dartanalyzer) are merged and de-duped when the lists contain relative paths, but merged and *not* de-duped when the lists contain absolute paths. gyp rejects xcode files that it generated itself when they contain duplicate entries. This CL works around that bug, by using absolute paths in the GN build and keeping relative paths in the gyp build. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ccfafee0239068d5c98017ae5e14ccef29c835c4

Patch Set 1 #

Patch Set 2 : Comments and checking in scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -57 lines) Patch
M BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M create_sdk.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/pkg_files.gyp View 1 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/BUILD.gn View 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/vm.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M tools/list_dart_files.py View 1 3 chunks +17 lines, -5 lines 0 comments Download
M tools/list_files.py View 1 2 chunks +16 lines, -4 lines 0 comments Download
M utils/compiler/compiler.gyp View 2 chunks +6 lines, -2 lines 0 comments Download
M utils/create_timestamp.gni View 2 chunks +2 lines, -11 lines 0 comments Download
M utils/dartanalyzer/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 1 3 chunks +12 lines, -6 lines 0 comments Download
M utils/dartdevc/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M utils/dartdevc/dartdevc.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M utils/dartdoc/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M utils/dartdoc/dartdoc.gyp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M utils/dartfmt/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M utils/dartfmt/dartfmt.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
zra
4 years ago (2016-12-13 05:42:47 UTC) #4
rmacnak
lgtm
4 years ago (2016-12-13 17:27:30 UTC) #5
zra
4 years ago (2016-12-13 18:01:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ccfafee0239068d5c98017ae5e14ccef29c835c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698