Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: runtime/vm/BUILD.gn

Issue 2567213002: Make list_files.py and list_dart_files.py return absolute paths for GN (Closed)
Patch Set: Comments and checking in scripts Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg_files.gyp ('k') | runtime/vm/vm.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/BUILD.gn
diff --git a/runtime/vm/BUILD.gn b/runtime/vm/BUILD.gn
index 9bbc3a495387183434e5b54bfb9dbcb56386bb29..bf3a4537b27f5472f2e8e931e0d970449eecdc74 100644
--- a/runtime/vm/BUILD.gn
+++ b/runtime/vm/BUILD.gn
@@ -411,10 +411,13 @@ if (!defined(is_fuchsia) || !is_fuchsia) {
script = "../../tools/patch_sdk.py"
- # We list all files which make up the sdk (modulo patches) and get them back
- # as a GN list object.
+ # We list all files which make up the sdk (modulo patches) and get them
+ # back as a GN list object.
shared_sdk_sources = exec_script("../../tools/list_dart_files.py",
- [ "../../sdk/lib" ],
+ [
+ "absolute",
+ rebase_path("../../sdk/lib"),
+ ],
"list lines")
# We list the `patch_sdk.dart` tool here because the [script] (which is
@@ -423,8 +426,8 @@ if (!defined(is_fuchsia) || !is_fuchsia) {
"../../tools/patch_sdk.dart",
]
- # Files below are not patches, they will not be in [concatenation_files] but
- # the `patch_sdk.dart` script will copy them into the patched sdk.
+ # Files below are not patches, they will not be in [concatenation_files]
+ # but the `patch_sdk.dart` script will copy them into the patched sdk.
inputs += [
"../lib/typed_data.dart",
"../bin/builtin.dart",
« no previous file with comments | « pkg/pkg_files.gyp ('k') | runtime/vm/vm.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698