Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2567173003:
Roll ANGLE d023939..c31b741 (Closed)
DescriptionRoll ANGLE d023939..c31b741
https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741
BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/d398b797dbcd4e88c229f0ba535198c087e15c2b
Cr-Commit-Position: refs/heads/master@{#438161}
Patch Set 1 #Messages
Total messages: 17 (10 generated)
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll ANGLE d023939..c31b741 https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741 BUG=308366,None,672380,668028,668223 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll ANGLE d023939..c31b741 https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741 BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
qiankun.miao@intel.com changed reviewers: + jmadill@chromium.org, kbr@chromium.org, zmo@chromium.org
Roll in unary minus workaround in ANGLE. Hook up patch is at: https://codereview.chromium.org/2567983002/ PTAL
lgtm
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
qiankun you should use the ANGLE roll script: chromium/src/tools/roll_angle.py. This change looks similar but the roll script should not append angleproject bugs to the description.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481638346576730, "parent_rev":
"8115f61df597b489adb0de1496d67604a73aa7c5", "commit_rev":
"a62bc314b8b4ba475f73dd7461c0f6af612a716e"}
Message was sent while issue was closed.
Description was changed from ========== Roll ANGLE d023939..c31b741 https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741 BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll ANGLE d023939..c31b741 https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741 BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2567173003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll ANGLE d023939..c31b741 https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741 BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2567173003 ========== to ========== Roll ANGLE d023939..c31b741 https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741 BUG=308366, 672380, 668028, 668223, angleproject:1523, angleproject:523 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/d398b797dbcd4e88c229f0ba535198c087e15c2b Cr-Commit-Position: refs/heads/master@{#438161} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d398b797dbcd4e88c229f0ba535198c087e15c2b Cr-Commit-Position: refs/heads/master@{#438161}
Message was sent while issue was closed.
On 2016/12/13 14:13:25, Jamie Madill wrote: > qiankun you should use the ANGLE roll script: chromium/src/tools/roll_angle.py. > This change looks similar but the roll script should not append angleproject > bugs to the description. Thank you. I used the script to roll, but I added angle bug manually. I expected the angle bug should be in description before. I will keep chromium bug only in future. |
