Issue 2567163002: Use kFunctionCid instead of kIllegalCid to indicate that a generic function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2567163002: Use kFunctionCid instead of kIllegalCid to indicate that a generic function (Closed)

Created:
4 years ago by regis

Modified:
4 years ago

Reviewers:
rmacnak, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use kFunctionCid instead of kIllegalCid to indicate that a generic function type parameter does not parameterize a class, but a function. Snapshot generation apparently trips on kIllegalCid. R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/53e93e8b053674b1a260d01156c92165438f8d36

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/vm/object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/object.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

regis

4 years ago (2016-12-12 22:13:23 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
53e93e8b053674b1a260d01156c92165438f8d36 (presubmit successful).