Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 2567133002: Add support for the new function-type syntax. (Closed)
Patch Set: Add new test and remove generated tests for this CL. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/diagnostics/messages.dart
diff --git a/pkg/compiler/lib/src/diagnostics/messages.dart b/pkg/compiler/lib/src/diagnostics/messages.dart
index d9785c64cca93be434ed7b0bd0a89e4293362269..3f445bea2159ec1578679388d4608f21902bffdf 100644
--- a/pkg/compiler/lib/src/diagnostics/messages.dart
+++ b/pkg/compiler/lib/src/diagnostics/messages.dart
@@ -275,6 +275,7 @@ enum MessageKind {
INVALID_RECEIVER_IN_INITIALIZER,
INVALID_SOURCE_FILE_LOCATION,
INVALID_SYMBOL,
+ INVALID_INLINE_FUNCTION_TYPE,
INVALID_SYNC_MODIFIER,
INVALID_TYPE_VARIABLE_BOUND,
INVALID_UNNAMED_CONSTRUCTOR_NAME,
@@ -3319,6 +3320,14 @@ Please include the following information:
" require a preamble file located in:\n"
" <sdk>/lib/_internal/js_runtime/lib/preambles."),
+ MessageKind.INVALID_INLINE_FUNCTION_TYPE: const MessageTemplate(
+ MessageKind.INVALID_INLINE_FUNCTION_TYPE,
+ "Invalid inline function type.",
+ howToFix: "Change the inline function type to a prefixed "
ahe 2017/02/14 12:43:02 "Change" -> "Try changing" I think this message c
floitsch 2017/02/14 13:56:17 Changed to: Try changing the inline function type
ahe 2017/02/15 11:50:17 It's tricky. Ideally, we would say "Try this: '...
+ "function type using the `Function` keyword.",
+ examples: const ["typedef F = Function(int f(String x))"],
+ ),
+
MessageKind.INVALID_SYNC_MODIFIER: const MessageTemplate(
MessageKind.INVALID_SYNC_MODIFIER, "Invalid modifier 'sync'.",
howToFix: "Try replacing 'sync' with 'sync*'.",

Powered by Google App Engine
This is Rietveld 408576698