Chromium Code Reviews| Index: pkg/front_end/lib/src/fasta/parser/listener.dart |
| diff --git a/pkg/front_end/lib/src/fasta/parser/listener.dart b/pkg/front_end/lib/src/fasta/parser/listener.dart |
| index 01d30edeffe24a2644c90eefa5f1623c944d4348..f8c0d69c20cf4ad4aaf46fee8b3531ea4acebefe 100644 |
| --- a/pkg/front_end/lib/src/fasta/parser/listener.dart |
| +++ b/pkg/front_end/lib/src/fasta/parser/listener.dart |
| @@ -224,10 +224,10 @@ class Listener { |
| logEvent("FunctionName"); |
| } |
| - void beginFunctionTypeAlias(Token token) {} |
| + void beginTypedef(Token token) {} |
|
ahe
2017/02/14 12:43:02
Why rename this?
floitsch
2017/02/14 13:56:17
Because it's the end of a `typedef`, and we are co
ahe
2017/02/15 11:50:17
That's precisely why I'd like to keep calling this
|
| - void endFunctionTypeAlias(Token typedefKeyword, Token endToken) { |
| - logEvent("FunctionTypeAlias"); |
| + void endTypedef(Token typedefKeyword, Token equals, Token endToken) { |
| + logEvent("Typedef"); |
| } |
| void beginMixinApplication(Token token) {} |
| @@ -504,7 +504,7 @@ class Listener { |
| /// This event is added for convenience. Normally, one should use |
| /// [endClassDeclaration], [endNamedMixinApplication], [endEnum], |
| - /// [endFunctionTypeAlias], [endLibraryName], [endImport], [endExport], |
| + /// [endTypedef], [endLibraryName], [endImport], [endExport], |
| /// [endPart], [endPartOf], [endTopLevelFields], or [endTopLevelMethod]. |
| void endTopLevelDeclaration(Token token) { |
| logEvent("TopLevelDeclaration"); |
| @@ -554,6 +554,10 @@ class Listener { |
| logEvent("Type"); |
| } |
| + void handleNoName(Token token) {} |
| + |
| + void endFunctionType(Token functionToken, Token endToken) {} |
|
ahe
2017/02/14 12:43:02
I can't find a matching beginFunctionType.
floitsch
2017/02/14 13:56:17
There is none. The parser doesn't see when a funct
ahe
2017/02/15 11:50:17
Could you document this here and on beginType? It'
floitsch
2017/02/16 16:30:15
Changed to 'handleFunctionType' (same for "handleT
|
| + |
| void beginTypeArguments(Token token) {} |
| void endTypeArguments(int count, Token beginToken, Token endToken) { |