Remove 'transport' paths from PassThroughImageTransportSurface

Remove 'transport' paths from PassThroughImageTransportSurface

BUG=None
R=jschuh@chromium.org, sievers@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266290

[piman, 2014-04-25 05:41:14]

https://codereview.chromium.org/256713002/diff/1/content/common/gpu/image_tra...
File content/common/gpu/image_transport_surface_android.cc (left):

https://codereview.chromium.org/256713002/diff/1/content/common/gpu/image_tra...
content/common/gpu/image_transport_surface_android.cc:81: :
PassThroughImageTransportSurface(manager, stub, surface, true),
This is the only one that was setting it to true.
However, it's been a long time since SwapBuffers, etc. were going through the
"transport" path (e.g. SwapBuffers is actually marked NOTREACHED), so I think
it's ok to assume it could just as well be false.

Let me know if I'm missing something here.

[no sievers, 2014-04-25 17:51:00]

LGTM

https://codereview.chromium.org/256713002/diff/1/content/common/gpu/image_tra...
File content/common/gpu/image_transport_surface.cc (left):

https://codereview.chromium.org/256713002/diff/1/content/common/gpu/image_tra...
content/common/gpu/image_transport_surface.cc:351:
helper_->SendResizeView(size);
ImageTransportHelper::SendResizeView(), GpuHostMsg_ResizeView,
GpuProcessHostUiShim::OnResizeView(), RWHVPort/Base::ResizeCompositingSurface()
look unused now and can probably be removed too.

https://codereview.chromium.org/256713002/diff/1/content/common/gpu/image_tra...
File content/common/gpu/image_transport_surface_android.cc (left):

https://codereview.chromium.org/256713002/diff/1/content/common/gpu/image_tra...
content/common/gpu/image_transport_surface_android.cc:81: :
PassThroughImageTransportSurface(manager, stub, surface, true),
On 2014/04/25 05:41:14, piman wrote:
> This is the only one that was setting it to true.
> However, it's been a long time since SwapBuffers, etc. were going through the
> "transport" path (e.g. SwapBuffers is actually marked NOTREACHED), so I think
> it's ok to assume it could just as well be false.
> 
> Let me know if I'm missing something here.

Should be fine. We don't expect glSwapBuffers() or glResizeCHROMIUM() here with
Ubercomp (or previously MailboxOutputSurface), which is the code which you are
removing. It wouldn't even have worked for resize, since we'd have stayed
descheduled and never gotten an ack from the browser.

[piman, 2014-04-25 19:14:34]

On Fri, Apr 25, 2014 at 10:51 AM, <sievers@chromium.org> wrote:

> LGTM
>
>
> https://codereview.chromium.org/256713002/diff/1/content/
> common/gpu/image_transport_surface.cc
> File content/common/gpu/image_transport_surface.cc (left):
>
> https://codereview.chromium.org/256713002/diff/1/content/
> common/gpu/image_transport_surface.cc#oldcode351
> content/common/gpu/image_transport_surface.cc:351:
> helper_->SendResizeView(size);
> ImageTransportHelper::SendResizeView(), GpuHostMsg_ResizeView,
> GpuProcessHostUiShim::OnResizeView(),
> RWHVPort/Base::ResizeCompositingSurface() look unused now and can
> probably be removed too.


Oh good point! I thought it was still used by mac but it isn't. Let me
remove it.

>
>
> https://codereview.chromium.org/256713002/diff/1/content/
> common/gpu/image_transport_surface_android.cc
> File content/common/gpu/image_transport_surface_android.cc (left):
>
> https://codereview.chromium.org/256713002/diff/1/content/
> common/gpu/image_transport_surface_android.cc#oldcode81
> content/common/gpu/image_transport_surface_android.cc:81: :
> PassThroughImageTransportSurface(manager, stub, surface, true),
> On 2014/04/25 05:41:14, piman wrote:
>
>> This is the only one that was setting it to true.
>> However, it's been a long time since SwapBuffers, etc. were going
>>
> through the
>
>> "transport" path (e.g. SwapBuffers is actually marked NOTREACHED), so
>>
> I think
>
>> it's ok to assume it could just as well be false.
>>
>
>  Let me know if I'm missing something here.
>>
>
> Should be fine. We don't expect glSwapBuffers() or glResizeCHROMIUM()
> here with Ubercomp (or previously MailboxOutputSurface), which is the
> code which you are removing. It wouldn't even have worked for resize,
> since we'd have stayed descheduled and never gotten an ack from the
> browser.
>
> https://codereview.chromium.org/256713002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[piman, 2014-04-25 19:47:17]

PTAL, removed those paths.
Also +jschuh for removing a couple of IPCs

[no sievers, 2014-04-25 19:54:07]

LGTM

[jschuh, 2014-04-25 23:09:31]

ipc security lgtm (message removal)

[piman, 2014-04-25 23:40:19]

The CQ bit was checked by piman@chromium.org

[piman, 2014-04-25 23:42:03]

Committed patchset #2 manually as r266290 (presubmit successful).