Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2567123002: Sysroot: Add build_and_upload.py (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sysroot: Add build_and_upload.py This CL adds a new script that automates building and uploading new sysroot images. Previously, you had to run UpdatePackageListsAll, BuildSysrootAll, and UploadSysrootAll for each of the 4 sysroot-creators. Then, you had to manually update the revision and sha1sum in install_sysroot.py. Now, simply run build_and_upload.py and your CL should be ready to go. In addition, the script concurrently updates each sysroot image (there are currently 11 of them), greatly reducing the time it took to update the sysroots. In addition to adding the script, this CL also rolls all sysroots. R=dpranke@chromium.org Committed: https://crrev.com/4c8b67057de3ee3f6c4105a0dceebc0228d9832e Cr-Commit-Position: refs/heads/master@{#438862}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address sbc@'s comments #

Total comments: 18

Patch Set 3 : Address more of sbc@'s comments #

Total comments: 4

Patch Set 4 : Return non-zero exit code if any sysroot builds failed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -93 lines) Patch
A build/linux/sysroot_scripts/build_and_upload.py View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 1 2 4 chunks +10 lines, -45 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.precise.amd64 View 2 chunks +3 lines, -3 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.trusty.arm View 2 chunks +3 lines, -3 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator.sh View 1 2 5 chunks +45 lines, -4 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 3 chunks +3 lines, -3 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-precise.sh View 3 chunks +6 lines, -4 lines 0 comments Download
D build/linux/sysroot_scripts/sysroot-creator-test.sh View 1 chunk +0 lines, -23 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 3 chunks +7 lines, -5 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 2 chunks +3 lines, -3 lines 0 comments Download
A build/linux/sysroot_scripts/sysroots.json View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
Tom (Use chromium acct)
+dpranke@ since we were discussing this the other day. I know you're busing making tryserver.chromium.linux ...
4 years ago (2016-12-12 18:49:58 UTC) #1
Tom (Use chromium acct)
4 years ago (2016-12-12 18:51:53 UTC) #2
Sam Clegg
I like some parts of this CL. Is there some way we could keep it ...
4 years ago (2016-12-12 19:18:00 UTC) #4
Tom (Use chromium acct)
On 2016/12/12 19:18:00, Sam Clegg wrote: > I like some parts of this CL. Is ...
4 years ago (2016-12-12 21:19:34 UTC) #5
Sam Clegg
https://codereview.chromium.org/2567123002/diff/20001/build/linux/sysroot_scripts/build_and_upload.py File build/linux/sysroot_scripts/build_and_upload.py (right): https://codereview.chromium.org/2567123002/diff/20001/build/linux/sysroot_scripts/build_and_upload.py#newcode60 build/linux/sysroot_scripts/build_and_upload.py:60: try: I seems like "with lock:" should work here. ...
4 years ago (2016-12-12 22:11:52 UTC) #8
Tom (Use chromium acct)
https://codereview.chromium.org/2567123002/diff/20001/build/linux/sysroot_scripts/build_and_upload.py File build/linux/sysroot_scripts/build_and_upload.py (right): https://codereview.chromium.org/2567123002/diff/20001/build/linux/sysroot_scripts/build_and_upload.py#newcode60 build/linux/sysroot_scripts/build_and_upload.py:60: try: On 2016/12/12 22:11:52, Sam Clegg wrote: > I ...
4 years ago (2016-12-13 00:06:19 UTC) #11
Sam Clegg
OK, this mostly lgtm now. I'm still not a huge fan of the use of ...
4 years ago (2016-12-13 00:30:37 UTC) #13
Tom (Use chromium acct)
https://codereview.chromium.org/2567123002/diff/40001/build/linux/sysroot_scripts/build_and_upload.py File build/linux/sysroot_scripts/build_and_upload.py (right): https://codereview.chromium.org/2567123002/diff/40001/build/linux/sysroot_scripts/build_and_upload.py#newcode91 build/linux/sysroot_scripts/build_and_upload.py:91: print "%s sysroot creation\t%s" % (name, status) On 2016/12/13 ...
4 years ago (2016-12-13 02:33:09 UTC) #14
Sam Clegg
On 2016/12/13 02:33:09, Tom Anderson wrote: > https://codereview.chromium.org/2567123002/diff/40001/build/linux/sysroot_scripts/build_and_upload.py > File build/linux/sysroot_scripts/build_and_upload.py (right): > > https://codereview.chromium.org/2567123002/diff/40001/build/linux/sysroot_scripts/build_and_upload.py#newcode91 ...
4 years ago (2016-12-13 16:45:11 UTC) #15
Tom (Use chromium acct)
pinging dpranke@ (thestig@ is OOO) On 2016/12/13 16:45:11, Sam Clegg wrote: > On 2016/12/13 02:33:09, ...
4 years ago (2016-12-14 03:39:08 UTC) #17
Dirk Pranke
lgtm
4 years ago (2016-12-15 01:55:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567123002/60001
4 years ago (2016-12-15 01:56:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/335030) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 02:03:26 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567123002/60001
4 years ago (2016-12-15 17:22:29 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-15 17:35:15 UTC) #32
commit-bot: I haz the power
4 years ago (2016-12-15 17:38:53 UTC) #34
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4c8b67057de3ee3f6c4105a0dceebc0228d9832e
Cr-Commit-Position: refs/heads/master@{#438862}

Powered by Google App Engine
This is Rietveld 408576698