Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2567113004:
Mark layout tests using 'filter: url(...)' as flaky (Closed)
DescriptionMark layout tests using 'filter: url(...)' as flaky
BUG=658305
R=fs@opera.com
NOTRY=true
Committed: https://crrev.com/c269a43c7619112f4096f27a9b5d5312103bed33
Cr-Commit-Position: refs/heads/master@{#438154}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Mark layout tests using 'filter: url(...)' as flaky BUG=658305 R=fs@opera.com ========== to ========== Mark layout tests using 'filter: url(...)' as flaky BUG=658305 R=fs@opera.com NOTRY=true ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2567113004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2567113004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:1124: crbug.com/658305 css3/filters/effect-all-on-background-expected.html [ Failure Pass ] No need to add the *-expected.html files (they are references. I see a bunch more below.)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2567113004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2567113004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:1124: crbug.com/658305 css3/filters/effect-all-on-background-expected.html [ Failure Pass ] On 2016/12/13 12:48:59, fs wrote: > No need to add the *-expected.html files (they are references. I see a bunch > more below.) Oops, sorry. Fixed.
lgtm
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481635320575780,
"parent_rev": "50818eea070fe65b6e940a06c8f3afaaba4c96c3", "commit_rev":
"aea96407304a13830cc75398c20cd92a960d881f"}
Message was sent while issue was closed.
Description was changed from ========== Mark layout tests using 'filter: url(...)' as flaky BUG=658305 R=fs@opera.com NOTRY=true ========== to ========== Mark layout tests using 'filter: url(...)' as flaky BUG=658305 R=fs@opera.com NOTRY=true Review-Url: https://codereview.chromium.org/2567113004 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Mark layout tests using 'filter: url(...)' as flaky BUG=658305 R=fs@opera.com NOTRY=true Review-Url: https://codereview.chromium.org/2567113004 ========== to ========== Mark layout tests using 'filter: url(...)' as flaky BUG=658305 R=fs@opera.com NOTRY=true Committed: https://crrev.com/c269a43c7619112f4096f27a9b5d5312103bed33 Cr-Commit-Position: refs/heads/master@{#438154} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c269a43c7619112f4096f27a9b5d5312103bed33 Cr-Commit-Position: refs/heads/master@{#438154} |
