Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2567113002: Adds ability to specify how aura::Env is created in content (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds ability to specify how aura::Env is created in content aura::Env::CreateInstance() takes a type. This patch plumbs the type through to content::MainFunctionParams and Content::ConteintMainParams so that consumers can specify how they want Env configured. BUG=672932 TEST=none R=jam@chromium.org Committed: https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9 Cr-Commit-Position: refs/heads/master@{#438023}

Patch Set 1 #

Patch Set 2 : more ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M content/app/content_main_runner.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/app/content_main.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/common/main_function_params.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
4 years ago (2016-12-12 18:34:45 UTC) #1
jam
lgtm
4 years ago (2016-12-13 01:29:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567113002/20001
4 years ago (2016-12-13 01:44:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:25:09 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-13 03:26:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9
Cr-Commit-Position: refs/heads/master@{#438023}

Powered by Google App Engine
This is Rietveld 408576698