Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2567043003: Revert of Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl (patchset #7 id:120001 of https://codereview.chromium.org/2558223002/ ) Reason for revert: BUG=673736 Original issue's description: > Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl > > Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl to AwContentsClientBridge. This is a continuation of the work started in > https://codereview.chromium.org/2425423004/ and is the third patch. > > BUG=645983 > > Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a > Cr-Commit-Position: refs/heads/master@{#437688} TBR=sgurun@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645983 Committed: https://crrev.com/0781d318118277e85563bc57c6d2e19b505f2a17 Cr-Commit-Position: refs/heads/master@{#438221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -356 lines) Patch
M android_webview/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge_base.h View 2 chunks +0 lines, -13 lines 0 comments Download
M android_webview/browser/aw_contents_io_thread_client.h View 2 chunks +10 lines, -0 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.cc View 3 chunks +9 lines, -28 lines 0 comments Download
D android_webview/browser/net/aw_web_resource_request.h View 1 chunk +0 lines, -57 lines 0 comments Download
D android_webview/browser/net/aw_web_resource_request.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 4 chunks +12 lines, -24 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +32 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java View 2 chunks +1 line, -84 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java View 2 chunks +72 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java View 1 chunk +12 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +0 lines, -7 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 3 chunks +0 lines, -74 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 8 chunks +122 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
boliu
Created Revert of Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl
4 years ago (2016-12-13 16:47:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567043003/1
4 years ago (2016-12-13 16:47:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 18:00:59 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 18:04:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0781d318118277e85563bc57c6d2e19b505f2a17
Cr-Commit-Position: refs/heads/master@{#438221}

Powered by Google App Engine
This is Rietveld 408576698