Add Precache global ranking config to test list.

Add Precache global ranking config to test list.

BUG=654166
Review-Url: https://codereview.chromium.org/2567033004
Cr-Commit-Position: refs/heads/master@{#442349}
Committed: https://chromium.googlesource.com/chromium/src/+/2bc003a0eadbd4062770b206fa76311f55d0c54e

[twifkak, 2016-12-13 20:39:06]

twifkak@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-12-13 20:41:27]

lgtm

[Alexei Svitkine (slow), 2016-12-13 20:41:59]

https://codereview.chromium.org/2567033004/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2567033004/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:1469: "name":
"EnabledGlobalRanking",
Actually, put this first or remove the Enabled group.

The first config is what receives the test coverage.

[twifkak, 2016-12-13 20:43:16]

https://codereview.chromium.org/2567033004/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config.json (right):

https://codereview.chromium.org/2567033004/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config.json:1469: "name":
"EnabledGlobalRanking",
On 2016/12/13 20:41:59, Alexei Svitkine (OO from 15th) wrote:
> Actually, put this first or remove the Enabled group.
> 
> The first config is what receives the test coverage.

Oh, well the first config is what is being run on 1% of stable, so I'd prefer
that to be covered.

[Alexei Svitkine (slow), 2016-12-13 20:52:15]

lgtm

[twifkak, 2016-12-13 21:18:47]

Description was changed from

==========
Add Precache global ranking config to test list.

BUG=654166
==========

to

==========
Add Precache global ranking config to test list.

BUG=654166
==========

[Alexei Svitkine (slow), 2017-01-06 19:27:39]

Friendly-ping - I'm wondering what's the status on this?

On Tue, Dec 13, 2016 at 3:52 PM, <asvitkine@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/2567033004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[twifkak, 2017-01-07 02:16:45]

Patchset #2 (id:20001) has been deleted

[twifkak, 2017-01-07 02:23:54]

On 2017/01/06 19:27:39, Alexei Svitkine (slow) wrote:
> Friendly-ping - I'm wondering what's the status on this?

PTAL. I'm ready to promote this experiment to stable (CL to come), so it's time
for this change as well.

[Alexei Svitkine (slow), 2017-01-09 16:38:53]

LGTM

Not sure why it showed up purple in the comment thread - as if it was already
landed?

[twifkak, 2017-01-09 20:16:29]

On 2017/01/09 16:38:53, Alexei Svitkine (slow) wrote:
> LGTM
> 
> Not sure why it showed up purple in the comment thread - as if it was already
> landed?

I'd closed it manually to get it off our dashboards because it was delayed
indefinitely. I reopened it when you pinged.

[twifkak, 2017-01-09 20:17:34]

On 2017/01/09 20:16:29, twifkak wrote:
> On 2017/01/09 16:38:53, Alexei Svitkine (slow) wrote:
> > LGTM
> > 
> > Not sure why it showed up purple in the comment thread - as if it was
already
> > landed?
> 
> I'd closed it manually to get it off our dashboards because it was delayed
> indefinitely. I reopened it when you pinged.

BTW thanks for the ping; it turns out to be the perfect time to run the
experiment.

[twifkak, 2017-01-09 20:17:53]

The CQ bit was checked by twifkak@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:23:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483993073135010,
"parent_rev": "c2d25780176f5daf3c1f23f27b76a610da66d40c", "commit_rev":
"2bc003a0eadbd4062770b206fa76311f55d0c54e"}

[commit-bot: I haz the power, 2017-01-09 21:23:54]

Description was changed from

==========
Add Precache global ranking config to test list.

BUG=654166
==========

to

==========
Add Precache global ranking config to test list.

BUG=654166

Review-Url: https://codereview.chromium.org/2567033004
Cr-Commit-Position: refs/heads/master@{#442349}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bc003a0eadbd4062770b206fa76...
==========

[commit-bot: I haz the power, 2017-01-09 21:23:55]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2bc003a0eadbd4062770b206fa76...